xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Bastian Blank <waldi@debian.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH 1/3] xen: Control-flow cleanup
Date: Wed, 24 Mar 2010 23:51:44 +0100	[thread overview]
Message-ID: <20100324225144.GA30197@wavehammer.waldi.eu.org> (raw)
In-Reply-To: <4BAA5189.8080503@goop.org>

On Wed, Mar 24, 2010 at 10:53:13AM -0700, Jeremy Fitzhardinge wrote:
> Thanks, I agree, but I tweaked it to use "goto out" to preserve the  
> single return, and fixed some lines which can now be unwrapped with the  
> shallower indent.

What is the reason for this single return except that it makes the code
less readable?

Bastian

-- 
Totally illogical, there was no chance.
		-- Spock, "The Galileo Seven", stardate 2822.3

      reply	other threads:[~2010-03-24 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 11:51 [PATCH 1/3] xen: Control-flow cleanup Bastian Blank
2010-03-24 17:53 ` Jeremy Fitzhardinge
2010-03-24 22:51   ` Bastian Blank [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100324225144.GA30197@wavehammer.waldi.eu.org \
    --to=waldi@debian.org \
    --cc=jeremy@goop.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).