From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Blank Subject: Re: [PATCH 1/3] xen: Control-flow cleanup Date: Wed, 24 Mar 2010 23:51:44 +0100 Message-ID: <20100324225144.GA30197@wavehammer.waldi.eu.org> References: <20100324115137.GA10770@wavehammer.waldi.eu.org> <4BAA5189.8080503@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <4BAA5189.8080503@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Mar 24, 2010 at 10:53:13AM -0700, Jeremy Fitzhardinge wrote: > Thanks, I agree, but I tweaked it to use "goto out" to preserve the > single return, and fixed some lines which can now be unwrapped with the > shallower indent. What is the reason for this single return except that it makes the code less readable? Bastian -- Totally illogical, there was no chance. -- Spock, "The Galileo Seven", stardate 2822.3