From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: xen-devel@lists.xensource.com
Subject: [PATCH] mini-os: Fix crash on frontend shutdown failures
Date: Tue, 6 Apr 2010 22:58:27 +0200 [thread overview]
Message-ID: <20100406205827.GL4015@const.famille.thibault.fr> (raw)
mini-os: Fix crash on frontend shutdown failures
Do not free frontend resources if some error happened, since the backend
may not have finished properly restarting in such case.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
diff -r adce8bc43fcc extras/mini-os/blkfront.c
--- a/extras/mini-os/blkfront.c Tue Apr 06 07:16:47 2010 +0100
+++ b/extras/mini-os/blkfront.c Tue Apr 06 22:54:33 2010 +0200
@@ -313,7 +313,8 @@
snprintf(path, sizeof(path), "%s/event-channel", nodename);
xenbus_rm(XBT_NIL, path);
- free_blkfront(dev);
+ if (!err)
+ free_blkfront(dev);
}
static void blkfront_wait_slot(struct blkfront_dev *dev)
diff -r adce8bc43fcc extras/mini-os/fbfront.c
--- a/extras/mini-os/fbfront.c Tue Apr 06 07:16:47 2010 +0100
+++ b/extras/mini-os/fbfront.c Tue Apr 06 22:54:33 2010 +0200
@@ -286,7 +288,8 @@
snprintf(path, sizeof(path), "%s/request-abs-pointer", nodename);
xenbus_rm(XBT_NIL, path);
- free_kbdfront(dev);
+ if (!err)
+ free_kbdfront(dev);
}
#ifdef HAVE_LIBC
@@ -676,7 +682,8 @@
snprintf(path, sizeof(path), "%s/feature-update", nodename);
xenbus_rm(XBT_NIL, path);
- free_fbfront(dev);
+ if (!err)
+ free_fbfront(dev);
}
#ifdef HAVE_LIBC
diff -r adce8bc43fcc extras/mini-os/netfront.c
--- a/extras/mini-os/netfront.c Tue Apr 06 07:16:47 2010 +0100
+++ b/extras/mini-os/netfront.c Tue Apr 06 22:54:33 2010 +0200
@@ -574,7 +574,8 @@
snprintf(path, sizeof(path), "%s/request-rx-copy", nodename);
xenbus_rm(XBT_NIL, path);
- free_netfront(dev);
+ if (!err)
+ free_netfront(dev);
}
diff -r adce8bc43fcc extras/mini-os/pcifront.c
--- a/extras/mini-os/pcifront.c Tue Apr 06 07:16:47 2010 +0100
+++ b/extras/mini-os/pcifront.c Tue Apr 06 22:54:33 2010 +0200
@@ -378,7 +378,8 @@
snprintf(path, sizeof(path), "%s/event-channel", nodename);
xenbus_rm(XBT_NIL, path);
- free_pcifront(dev);
+ if (!err)
+ free_pcifront(dev);
}
int pcifront_physical_to_virtual (struct pcifront_dev *dev,
reply other threads:[~2010-04-06 20:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100406205827.GL4015@const.famille.thibault.fr \
--to=samuel.thibault@ens-lyon.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).