From: Rafal Wojtczuk <rafal@invisiblethingslab.com>
To: xen-devel@lists.xensource.com
Cc: qubes-devel@googlegroups.com
Subject: Using xen-netfront in dom0
Date: Mon, 19 Apr 2010 10:26:24 +0200 [thread overview]
Message-ID: <20100419082624.GC18572@emperor2.itldev.org> (raw)
Hello,
In xen-netfront.c, there is an explicit check if we are running in dom0, and
if so, skip initialization:
http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=blob;f=drivers/net/xen-netfront.c;h=ee7465a7a2a9fa563f44a470bdad1911e175d1ad;hb=xen/stable-2.6.32.x#l1807
But if using a driver domain (with a NIC assigned), then definitely there is
a need to run xen-netfront in dom0. In fact, commenting out the
xen_initial_domain() check makes it work fine with a driver domain.
Is there any reason for this check, besides obviously false assumption
"nobody needs it in dom0" ? On a related note, there seems to be no such
check in xen-blkfront.c.
If there are no disadvantages, I would vote for removal of the
xen_initial_domain() check; otherwise, can we have a module parameter
"allow_dom0" ?
Regards,
Rafal Wojtczuk
The Qubes OS Project
http://qubes-os.org
next reply other threads:[~2010-04-19 8:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 8:26 Rafal Wojtczuk [this message]
2010-04-19 17:15 ` Using xen-netfront in dom0 Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100419082624.GC18572@emperor2.itldev.org \
--to=rafal@invisiblethingslab.com \
--cc=qubes-devel@googlegroups.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).