From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi Date: Tue, 20 Apr 2010 14:33:01 -0400 Message-ID: <20100420183301.GA32720@phenom.dumpdata.com> References: <4BC7C657.3010609@cn.fujitsu.com> <20100416145604.GC29398@phenom.dumpdata.com> <4BCA82FF.20901@cn.fujitsu.com> <4BCA8E9A.6090209@goop.org> <20100419133026.GA17501@phenom.dumpdata.com> <4BCD3C2B.3030706@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4BCD3C2B.3030706@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Yu Zhiguo Cc: Jeremy Fitzhardinge , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org > >> This is a good way of handling it. > > > > The header file change or the #ifdef in the acpi/boot.c file? > > Thanks for your explanation, I agree it is also a good idea. > But if jeremy think adding #ifdef is ok, I will not fix this patch. Huh? I thought that Jeremy mentioned that the #ifdef in the header file is the way to go. I was anticipating a patch from you for this... since I figured it isn't just as easy as that but there is probably some edge case I hadn't thought of.