From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
Date: Wed, 21 Apr 2010 09:00:45 -0400
Message-ID: <20100421130045.GA24393@phenom.dumpdata.com>
References: <4BC7C657.3010609@cn.fujitsu.com>
	<20100416145604.GC29398@phenom.dumpdata.com>
	<4BCA82FF.20901@cn.fujitsu.com> <4BCA8E9A.6090209@goop.org>
	<20100419133026.GA17501@phenom.dumpdata.com>
	<4BCD3C2B.3030706@cn.fujitsu.com>
	<20100420183301.GA32720@phenom.dumpdata.com>
	<4BCE7120.7020004@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <4BCE7120.7020004@cn.fujitsu.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Yu Zhiguo <yuzg@cn.fujitsu.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

> method-3)
> > Or maybe better take out the xen_register_gsi out of this double
> > #ifdef and move it to its own. Say:
> > 
> > 
> > #if !defined(CONFIG_XEN)
> > static int xen_register_gsi(..)
> > 
> > #endif
> 
> We must use #if !defined(CONFIG_XEN) || (defined(CONFIG_XEN) && !defined(CONFIG_XEN_DOM0_PCI)).
> It is ugly, especially if there are more macros.

Lets go with this one. Maybe after this is done there will be a way to
unmangle this spaghetti mess.