xenstored vanished

xenstored vanished

[Christoph Egger]

Hi!

I can't start xend as it can't find xenstored anymore.

What happened ?

Christoph



-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: xenstored vanished

[Keir Fraser]

On 07/05/2010 09:57, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

> 
> Hi!
> 
> I can't start xend as it can't find xenstored anymore.
> 
> What happened ?

Nothing's changed - it's still there for me.

 -- Keir

> Christoph
> 
> 

Re: xenstored vanished

[Christoph Egger]

On Friday 07 May 2010 10:57:54 Christoph Egger wrote:
> Hi!
>
> I can't start xend as it can't find xenstored anymore.
>
> What happened ?
>
> Christoph

OCAML_TOOLS are unconditionally enabled but I haven't installed
the ocaml tools. So xenstored got build but not installed.
I'm wondering why the build process did not fail.

Please only build ocaml version when ocaml is installed.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Re: xenstored vanished

[Keir Fraser]

On 07/05/2010 10:17, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> I can't start xend as it can't find xenstored anymore.
>> 
>> What happened ?
>> 
>> Christoph
> 
> OCAML_TOOLS are unconditionally enabled but I haven't installed
> the ocaml tools. So xenstored got build but not installed.
> I'm wondering why the build process did not fail.
> 
> Please only build ocaml version when ocaml is installed.

That is already the case:

ifeq ($(OCAML_TOOLS),y)
ifeq ($(CONFIG_Linux),y)
OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1 && echo "y" || echo "n")
else
OCAML_TOOLS := n
endif
endif

I can only conclude that you do have the ocaml toolchain installed. The
ocaml stuff was broken when first checked in, but it's now building okay for
me (e.g., current tip, c/s 21326).

If you are building on NetBSD then as you can see above, the ocaml build is
forcibly disabled on non-Linux systems.

 -- Keir

Re: xenstored vanished

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 1440 bytes --]

On Friday 07 May 2010 11:24:28 Keir Fraser wrote:
> On 07/05/2010 10:17, "Christoph Egger" <Christoph.Egger@amd.com> wrote:
> >> I can't start xend as it can't find xenstored anymore.
> >>
> >> What happened ?
> >>
> >> Christoph
> >
> > OCAML_TOOLS are unconditionally enabled but I haven't installed
> > the ocaml tools. So xenstored got build but not installed.
> > I'm wondering why the build process did not fail.
> >
> > Please only build ocaml version when ocaml is installed.
>
> That is already the case:
>
> ifeq ($(OCAML_TOOLS),y)
> ifeq ($(CONFIG_Linux),y)
> OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1 && echo "y" || echo
> "n") else
> OCAML_TOOLS := n
> endif
> endif
>
> I can only conclude that you do have the ocaml toolchain installed. The
> ocaml stuff was broken when first checked in, but it's now building okay
> for me (e.g., current tip, c/s 21326).
>
> If you are building on NetBSD then as you can see above, the ocaml build is
> forcibly disabled on non-Linux systems.

Attached patch fixes my problem. xenstored (C version) is there again.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_ocaml.diff --]
[-- Type: text/x-diff, Size: 1271 bytes --]

diff -r 6f53b34a3a5a Config.mk
--- a/Config.mk	Fri May 07 10:41:50 2010 +0200
+++ b/Config.mk	Fri May 07 11:25:10 2010 +0200
@@ -163,15 +163,13 @@ XENSTAT_XENTOP     ?= y
 VTPM_TOOLS         ?= n
 LIBXENAPI_BINDINGS ?= n
 PYTHON_TOOLS       ?= y
-OCAML_TOOLS        ?= y
+OCAML_TOOLS        ?= n
 CONFIG_MINITERM    ?= n
 CONFIG_LOMOUNT     ?= n
 
 ifeq ($(OCAML_TOOLS),y)
 ifeq ($(CONFIG_Linux),y)
 OCAML_TOOLS := $(shell ocamlopt -v > /dev/null 2>&1 && echo "y" || echo "n")
-else
-OCAML_TOOLS := n
 endif
 endif
 
diff -r 6f53b34a3a5a tools/xenstore/Makefile
--- a/tools/xenstore/Makefile	Fri May 07 10:41:50 2010 +0200
+++ b/tools/xenstore/Makefile	Fri May 07 11:25:10 2010 +0200
@@ -27,7 +27,7 @@ xenstore xenstore-control: CFLAGS += -st
 endif
 
 ALL_TARGETS = libxenstore.so libxenstore.a clients xs_tdb_dump 
-ifneq ($(CONFIG_OCAML_XENSTORED),y)
+ifeq ($(OCAML_TOOLS),n)
  ALL_TARGETS += xenstored
 endif
 
@@ -95,6 +95,11 @@ tarball: clean
 
 .PHONY: install
 install: all
+ifeq ($(OCAML_TOOLS),n)
+	$(INSTALL_DIR) $(DESTDIR)/var/run/xenstored
+	$(INSTALL_DIR) $(DESTDIR)/var/lib/xenstored
+	$(INSTALL_PROG) xenstored $(DESTDIR)$(SBINDIR)
+endif
 	$(INSTALL_DIR) $(DESTDIR)$(BINDIR)
 	$(INSTALL_DIR) $(DESTDIR)$(SBINDIR)
 	$(INSTALL_DIR) $(DESTDIR)$(INCLUDEDIR)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: xenstored vanished

[Keir Fraser]

On 07/05/2010 10:47, "Christoph Egger" <Christoph.Egger@amd.com> wrote:

>> If you are building on NetBSD then as you can see above, the ocaml build is
>> forcibly disabled on non-Linux systems.
> 
> Attached patch fixes my problem. xenstored (C version) is there again.
> 
> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

Hm, well there's no need to install xenstored *or* oxenstored. They can
coexist. I'll fix the xenstore Makefile to install xenstored unconditionally
(although really it should be doing that anyway, since
CONFIG_OCAML_XENSTORED is not used any more).

 -- Keir

Re: xenstored vanished

[Keir Fraser]

On 07/05/2010 11:37, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:

>> Attached patch fixes my problem. xenstored (C version) is there again.
>> 
>> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> 
> Hm, well there's no need to install xenstored *or* oxenstored. They can
> coexist. I'll fix the xenstore Makefile to install xenstored unconditionally
> (although really it should be doing that anyway, since
> CONFIG_OCAML_XENSTORED is not used any more).

Try xen-unstable:21327. Sorry, I had missed a sneaky change to
xenstore/Makefile when reviewing c/s 21292, so indeed xenstored was never
getting installed. :-(

 -- Keir

Re: xenstored vanished

[Christoph Egger]

On Friday 07 May 2010 12:50:24 Keir Fraser wrote:
> On 07/05/2010 11:37, "Keir Fraser" <keir.fraser@eu.citrix.com> wrote:
> >> Attached patch fixes my problem. xenstored (C version) is there again.
> >>
> >> Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
> >
> > Hm, well there's no need to install xenstored *or* oxenstored. They can
> > coexist. I'll fix the xenstore Makefile to install xenstored
> > unconditionally (although really it should be doing that anyway, since
> > CONFIG_OCAML_XENSTORED is not used any more).
>
> Try xen-unstable:21327. Sorry, I had missed a sneaky change to
> xenstore/Makefile when reviewing c/s 21292, so indeed xenstored was never
> getting installed. :-(

Yes, that works again. Thanks.

Christoph
-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632