From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Wang2 Subject: Re: [PATCH] svm: Avoid VINTR injection during NMI shadow Date: Fri, 7 May 2010 19:18:12 +0200 Message-ID: <201005071918.12980.wei.wang2@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org Totally agree, you are are right only NMI injection should be avoid. I have tested that the new condition works well. Thanks. Wei On Friday 07 May 2010 18:56:32 Keir Fraser wrote: > I think the if statement should be: > if ((vmcb->general1_intercepts & GENERAL1_INTERCEPT_IRET) && > (intack.source =3D=3D hvm_intsrc_nmi)) > return; > > Which I think deals properly and specifically with this hang problem. > > What do you think? > > -- Keir > > On 07/05/2010 15:41, "Wei Wang2" wrote: > > Hi, > > I had observed that if xen injects and intercepts VINTR during NMI > > shadow, and if the xen injects NMI into guest at a very hight frequency, > > guest vcpu will hang. Attached patch avoids VINTR injection when guest = is > > handling a NMI. > > > > Thanks, > > > > Wei > > Signed-off-by: Wei Wang > > Reviewed-by: Wei Huang > > -- > > Legal Information: > > Advanced Micro Devices GmbH > > Karl-Hammerschmidt-Str. 34 > > 85609 Dornach b. M=FCnchen > > > > Gesch=E4ftsf=FChrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni > > Sitz: Dornach, Gemeinde Aschheim, Landkreis M=FCnchen > > Registergericht M=FCnchen, HRB Nr. 43632