From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mukesh Rathor <mukesh.rathor@oracle.com>
Subject: Re: [patch] ext/debugger.hgs: add missing includes
Date: Mon, 10 May 2010 18:25:41 -0700
Message-ID: <20100510182541.7384a32b@mantra.us.oracle.com>
References: <FFDB98DC9661D3418B9EB0FF5202E46B7A803EBD9B@LONPMAILBOX01.citrite.net>
	<FFDB98DC9661D3418B9EB0FF5202E46B7A803EBD9C@LONPMAILBOX01.citrite.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <FFDB98DC9661D3418B9EB0FF5202E46B7A803EBD9C@LONPMAILBOX01.citrite.net>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Goncalo Gomes <Goncalo.Gomes@eu.citrix.com>
Cc: "'xen-devel@lists.xensource.com'" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Sat, 8 May 2010 21:12:25 +0100
Goncalo Gomes <Goncalo.Gomes@eu.citrix.com> wrote:

> The changes below are required to build Xen 4.0rc6 from the
> debuggers.hg with enabled gdbsx support.
> 
> Cheers,
>  -Goncalo.
> 
> Signed-off-by: Goncalo Gomes <Goncalo.Gomes@Eu.Citrix.COM>
> 
> diff -r 809b20f066fb xen/arch/x86/gdbstub.c
> --- a/xen/arch/x86/gdbstub.c	Fri Mar 19 18:36:57 2010 -0700
> +++ b/xen/arch/x86/gdbstub.c	Sat May 08 20:43:37 2010 +0100
> @@ -20,6 +20,7 @@
>   * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA
> 02111-1307 USA */
>  #include <asm/debugger.h>
> +#include <xen/gdbstub.h>
>  
>  u16
>  gdb_arch_signal_num(struct cpu_user_regs *regs, unsigned long cookie)
> diff -r 809b20f066fb xen/arch/x86/x86_64/gdbstub.c
> --- a/xen/arch/x86/x86_64/gdbstub.c	Fri Mar 19 18:36:57 2010
> -0700 +++ b/xen/arch/x86/x86_64/gdbstub.c	Sat May 08 20:43:37
> 2010 +0100 @@ -19,6 +19,7 @@
>   */
>  
>  #include <asm/debugger.h>
> +#include <xen/gdbstub.h>
>  
>  #define GDB_REG64(r) gdb_write_to_packet_hex(r, sizeof(u64), ctx)
>  #define GDB_REG32(r)  gdb_write_to_packet_hex(r, sizeof(u32), ctx)
> diff -r 809b20f066fb xen/common/gdbstub.c
> --- a/xen/common/gdbstub.c	Fri Mar 19 18:36:57 2010 -0700
> +++ b/xen/common/gdbstub.c	Sat May 08 20:43:37 2010 +0100
> @@ -45,6 +45,7 @@
>  #include <xen/errno.h>
>  #include <xen/delay.h>
>  #include <asm/byteorder.h>
> +#include <xen/gdbstub.h>
>  
>  /* Printk isn't particularly safe just after we've trapped to the
>     debugger. so avoid it. */

Hi Goncalo,

Can you please elaborate a bit. I was able to build using make gdbsx=y
crash_debug=y, is that what you are doing? I don't mind making the
change in the ext/debuggers.hg tree, but if the parallel change is not
in unstable tree, next time i refresh it may get overwritten to your
annoyance. i don't see gdbstub files with the above include in unstable
or xen 4.0 tree. Moroever, the gdbstub files have nothing to do with
either kdb or gdbsx. 

thanks,
mukesh