From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
Subject: Re: cpu_down() but no cpu_up() in
	drivers/xen/cpu_hotplug.c ?
Date: Tue, 11 May 2010 13:30:14 +0200
Message-ID: <201005111330.14929.dietmar.hahn@ts.fujitsu.com>
References: <4BE940C80200007800002410@vpn.id2.novell.com>
	<1273571127.7572.2905.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1273571127.7572.2905.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: Jeremy Fitzhardinge <jeremy@goop.org>, Ian Campbell <Ian.Campbell@citrix.com>, Jan Beulich <JBeulich@novell.com>
List-Id: xen-devel@lists.xenproject.org

Am 11.05.2010 schrieb Ian Campbell:
> On Tue, 2010-05-11 at 10:34 +0100, Jan Beulich wrote:
> > Jeremy,
> > 
> > how is pv-ops bringing up CPUs set to online in xenstore? Is this not
> > an automatic process (i.e. requires writing to respective online node
> > in sysfs), like in the traditional tree?
> 
> The original commit which added CPU hotplug to pvops says:
> 
>     xen: implement CPU hotplugging
>     
>     Note the changes from 2.6.18-xen CPU hotplugging:
>     
>     A vcpu_down request from the remote admin via Xenbus both hotunplugs the
>     CPU, and disables it by removing it from the cpu_present map, and removing
>     its entry in /sys.
>     
>     A vcpu_up request from the remote admin only re-enables the CPU, and does
>     not immediately bring the CPU up. A udev event is emitted, which can be
>     caught by the user if he wishes to automatically re-up CPUs when available,
>     or implement a more complex policy.
>     
>     Signed-off-by: Alex Nixon <alex.nixon@citrix.com>
>     Acked-by: Jeremy Fitzhardinge <jeremy@goop.org>
>     Signed-off-by: Ingo Molnar <mingo@elte.hu>
> 
> I'm not sure how the decision was reached to implement it this way,
> perhaps for consistency with CPU hotplug on other
> platforms/architectures?
> 
> FWIW I use a udev rule to bring up CPUs as they are added, which is
> equivalent to the old behaviour:
> 
>         ACTION=="add", SUBSYSTEM=="cpu", RUN+="/bin/sh -c '[ ! -e /sys$devpath/online ] || echo 1 > /sys$devpath/online'"
> 
> Ian.

Maybe it would be good then to have a comment somewhere in the tree with
this udev rule as a hint?
Thanks.

Dietmar.

-- 
Company details: http://ts.fujitsu.com/imprint.html