xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Subject: libxl: build fix
Date: Tue, 25 May 2010 11:36:17 +0200	[thread overview]
Message-ID: <201005251136.18205.Christoph.Egger@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 501 bytes --]


Hi!

Attached patch makes libxl build again on NetBSD.

The build error is:
warning: array subscript has type 'char'
Note, that we compile libxl with -Werror

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_libxl.diff --]
[-- Type: text/x-diff, Size: 413 bytes --]

diff -r 897d8b86deae tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Tue May 25 10:01:18 2010 +0200
+++ b/tools/libxl/xl_cmdimpl.c	Tue May 25 11:32:49 2010 +0200
@@ -1226,7 +1226,7 @@ static int64_t parse_mem_size_kb(char *m
     if (strlen(endptr) > 1)
         return -1;
 
-    switch (tolower(*endptr)) {
+    switch (tolower((uint8_t)*endptr)) {
     case 't':
         kbytes <<= 10;
     case 'g':

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-05-25  9:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-25  9:36 Christoph Egger [this message]
2010-05-27 14:41 ` libxl: build fix Ian Jackson
  -- strict thread matches above, loose matches on Subject: below --
2010-11-05 15:08 Christoph Egger
2010-11-08 16:38 ` Ian Jackson
2010-11-08 16:53   ` Christoph Egger
2010-11-08 17:01     ` Ian Jackson
2010-11-09 11:39       ` Christoph Egger
2010-11-09 11:54         ` Ian Jackson
2010-11-09 12:58           ` Christoph Egger
2010-11-09 13:27             ` John Haxby
2010-11-09 17:03               ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005251136.18205.Christoph.Egger@amd.com \
    --to=christoph.egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).