From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastian Blank Subject: [PATCH] xen/netback: Fix null-pointer access in netback_uevent Date: Sat, 29 May 2010 20:44:52 +0200 Message-ID: <20100529184452.GA18365@wavehammer.waldi.eu.org> References: <20100527165558.GA11358@wavehammer.waldi.eu.org> <20100528090325.GA13575@wavehammer.waldi.eu.org> <4BFFFD30.6000807@goop.org> <4C005228.5060107@goop.org> <20100529064411.GA12168@wavehammer.waldi.eu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20100529064411.GA12168@wavehammer.waldi.eu.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: James Harper , Jeremy Fitzhardinge , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org The uevent method of Xen netback does not check if the the network device is already setup and tries to dereference a null-pointer it not. Signed-off-by: Bastian Blank --- drivers/xen/netback/xenbus.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/xen/netback/xenbus.c b/drivers/xen/netback/xenbus.c index 70636d0..88262bb 100644 --- a/drivers/xen/netback/xenbus.c +++ b/drivers/xen/netback/xenbus.c @@ -163,7 +163,6 @@ fail: static int netback_uevent(struct xenbus_device *xdev, struct kobj_uevent_env *env) { struct backend_info *be = dev_get_drvdata(&xdev->dev); - struct xen_netif *netif = be->netif; char *val; DPRINTK("netback_uevent"); @@ -182,7 +181,7 @@ static int netback_uevent(struct xenbus_device *xdev, struct kobj_uevent_env *en kfree(val); } - if (add_uevent_var(env, "vif=%s", netif->dev->name)) + if (be && be->netif && add_uevent_var(env, "vif=%s", be->netif->dev->name)) return -ENOMEM; return 0; -- 1.7.1 -- To live is always desirable. -- Eleen the Capellan, "Friday's Child", stardate 3498.9