From: Dave McCracken <dcm@mccr.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Xen Developers List <xen-devel@lists.xensource.com>
Subject: Re: [Linux PATCH] Mark hugepages to the hypervisor to speed up mapping (with signoff this time)
Date: Wed, 9 Jun 2010 13:20:33 -0500 [thread overview]
Message-ID: <201006091320.34136.dcm@mccr.org> (raw)
In-Reply-To: <4C0FD790.3070603@goop.org>
On Wednesday, June 09, 2010, Jeremy Fitzhardinge wrote:
> > + return 1;
> > + }
> > + for (i = 0, m = mfn; i < HPAGE_SIZE/PAGE_SIZE; i++, pfn++, m++) {
> > + if (pfn_to_mfn(pfn) != m) {
> > + printk("Guest pages are not properly aligned to use
> > hugepages\n");
> >
> >
>
> Isn't this a superset of the previous test?
The code is doublechecking to make sure this hugepage is actually contiguous
at the machine level.
Dave McCracken
Oracle Corp.
prev parent reply other threads:[~2010-06-09 18:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-09 17:20 [Linux PATCH] Mark hugepages to the hypervisor to speed up mapping (with signoff this time) Dave McCracken
2010-06-09 18:04 ` Jeremy Fitzhardinge
2010-06-09 18:20 ` Dave McCracken [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006091320.34136.dcm@mccr.org \
--to=dcm@mccr.org \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).