From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] svm: use msr safe for erratum 383
Date: Fri, 11 Jun 2010 14:33:40 +0200 [thread overview]
Message-ID: <201006111433.40975.Christoph.Egger@amd.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
Hi!
Attached patch makes erratum 383 use msr safe variants
to work on top of KVM.
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
P.S.: Keir: Please apply this patch to Xen-4.0-testing, too.
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
[-- Attachment #2: xen_msr_svm.diff --]
[-- Type: text/x-diff, Size: 772 bytes --]
diff -r 125b3493dac9 xen/arch/x86/hvm/svm/svm.c
--- a/xen/arch/x86/hvm/svm/svm.c Fri Jun 11 11:37:22 2010 +0100
+++ b/xen/arch/x86/hvm/svm/svm.c Fri Jun 11 14:31:40 2010 +0200
@@ -849,10 +849,14 @@ static void svm_init_erratum_383(struct
if ( c->x86 != 0x10 )
return;
- rdmsrl(MSR_AMD64_DC_CFG, msr_content);
- wrmsrl(MSR_AMD64_DC_CFG, msr_content | (1ULL << 47));
-
- amd_erratum383_found = 1;
+ /* use safe methods to be compatible with nested virtualization */
+ if (rdmsr_safe(MSR_AMD64_DC_CFG, msr_content) == 0 &&
+ wrmsr_safe(MSR_AMD64_DC_CFG, msr_content | (1ULL << 47)) == 0)
+ {
+ amd_erratum383_found = 1;
+ } else {
+ printk("Failed to enable erratum 383\n");
+ }
}
static int svm_cpu_up(void)
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
reply other threads:[~2010-06-11 12:33 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201006111433.40975.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).