From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Keir@acsinet12.oracle.com, Fraser <Keir.Fraser@eu.citrix.com>,
Anthony.Perard@citrix.com, Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [PATCH 1 of 1] mini-os: PV fronted MUST be in XenbusStateConnected not XenbusStateInitialized during init
Date: Thu, 1 Jul 2010 10:05:49 -0400 [thread overview]
Message-ID: <20100701140549.GA31947@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1007011114290.30135@kaball-desktop>
On Thu, Jul 01, 2010 at 12:32:15PM +0100, Stefano Stabellini wrote:
> Thank you for the patch Konrad.
>
> I think this fix shows us that 805ed3b20492d2f4bb465bfda65cedd286e23209
> was the wrong fix:
>
> commit 805ed3b20492d2f4bb465bfda65cedd286e23209
> Author: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Fri May 21 15:46:55 2010 +0100
>
> Wait for frontend state Connected before connecting the backend
>
> The frontend of the framebuffer set a value
> (request-abs-pointer) and go
> to the state Connected. The backend must read this value
> only when the
> frontend has the state Connected.
>
>
> The problem was that the backend can be sure that the linux xenfb
> frontend wrote request-abs-pointer only after the frontend state is
> Connected.
> In order to do that properly we need a new hook in qemu xen_backend: we
> should probably rename the current connect hook to initialise and create
> a new connect hook that would be implemented by xenfb to read
> request-abs-pointer.
Uhh. How about a compromise. Lets put this hac^H^H^Hpatch in, and when the QEMU
fix is ready, yank this out and also the c/s 21260:
"mini-os: Revert 21106:b20f897d6010 "Fix xenbus initialisation"
Jeremy Fitzhardinge (jeremy@goop.org) reports that this fixes
HVM+stubdom."
which was fixing the same exact problem I did, but on the stubdomain
side?
next prev parent reply other threads:[~2010-07-01 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 14:30 [PATCH 0 of 1] PV-GRUB fix (actually MiniOS) when PV guest launched with vfb=[..] entry Konrad Rzeszutek Wilk
2010-06-30 14:30 ` [PATCH 1 of 1] mini-os: PV fronted MUST be in XenbusStateConnected not XenbusStateInitialized during init Konrad Rzeszutek Wilk
2010-07-01 11:32 ` Stefano Stabellini
2010-07-01 14:05 ` Konrad Rzeszutek Wilk [this message]
2010-07-01 14:32 ` Stefano Stabellini
2010-07-01 15:07 ` Ian Jackson
2010-06-30 16:24 ` [PATCH 0 of 1] PV-GRUB fix (actually MiniOS) when PV guest launched with vfb=[..] entry Keir Fraser
2010-07-01 11:36 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100701140549.GA31947@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Anthony.Perard@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=Keir@acsinet12.oracle.com \
--cc=kraxel@redhat.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).