From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Rathor Subject: [PATCH]: gdbsx: update README and remove space in q packet Date: Wed, 14 Jul 2010 19:36:26 -0700 Message-ID: <20100714193626.57259db1@mantra.us.oracle.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/ffcWk+1L2u5Wn9GIBlf1EQ9" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Xen-devel@lists.xensource.com" , Bruce Edge , Jeremy Fitzhardinge List-Id: xen-devel@lists.xenproject.org --MP_/ffcWk+1L2u5Wn9GIBlf1EQ9 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Newer version of gdb, version 7*, seems to have bug where it is not parsing thread list from gdbsx properly. Getting rid of the space in thread list works around it. It's ok with older gdb also. Signed-off-by: Mukesh Rathor diff -r d867eb643fe4 tools/debugger/gdbsx/README --- a/tools/debugger/gdbsx/README Tue Jul 13 18:17:28 2010 +0100 +++ b/tools/debugger/gdbsx/README Wed Jul 14 19:05:37 2010 -0700 @@ -26,7 +26,7 @@ bash> gdb ./vmlinux (exact matching vmlinux of guest kernel) (gdb) target remote dom0:9999 - - Additionally, to debug loadable kernel modules, please do following: + - Additionally, to debug 32bit loadable kernel modules, please do following: (gdb) p init_mm.pgd[3] $1 = {pgd = 0x1b874f027} (gdb) monitor pgd3 0x1b874f027 (Make sure value is in HEX) diff -r d867eb643fe4 tools/debugger/gdbsx/gx/gx_main.c --- a/tools/debugger/gdbsx/gx/gx_main.c Tue Jul 13 18:17:28 2010 +0100 +++ b/tools/debugger/gdbsx/gx/gx_main.c Wed Jul 14 19:05:37 2010 -0700 @@ -132,12 +132,12 @@ static void process_q_request(char *remote_buf) { - /* send a list of tids: "m 0,1,2,3l" */ + /* send a list of tids: "m0,1,2,3l" */ if (strcmp("qfThreadInfo", remote_buf) == 0) { vcpuid_t vid = 0; char *p = remote_buf; - sprintf(p, "m %x", vid); /* puts null char at the end */ + sprintf(p, "m%x", vid); /* puts null char at the end */ p = p + strlen(p); for (vid=1; vid <= max_vcpuid; vid++) { sprintf(p, ",%x", vid); @@ -146,8 +146,9 @@ sprintf(p, "l"); /* puts null char at the end */ return; } + /* qSymbol works for init_mm, and not init_mm.pgd, hence we can't use - * it at this time. instead use "monitor" in gdb */ + * it at this time. instead use "monitor" in gdb */ if (strncmp("qRcmd,", remote_buf, 6) == 0) { _do_qRcmd_req(remote_buf); return; @@ -155,8 +156,7 @@ /* TBD : qThreadExtraInfo : send extra banner info */ - /* nothing else supported right now */ - remote_buf[0] = '\0'; + remote_buf[0] = '\0'; /* nothing else supported for now */ return; } --MP_/ffcWk+1L2u5Wn9GIBlf1EQ9 Content-Type: application/octet-stream; name=diff.out Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=diff.out ZGlmZiAtciBkODY3ZWI2NDNmZTQgdG9vbHMvZGVidWdnZXIvZ2Ric3gvUkVBRE1FCi0tLSBhL3Rv b2xzL2RlYnVnZ2VyL2dkYnN4L1JFQURNRQlUdWUgSnVsIDEzIDE4OjE3OjI4IDIwMTAgKzAxMDAK KysrIGIvdG9vbHMvZGVidWdnZXIvZ2Ric3gvUkVBRE1FCVdlZCBKdWwgMTQgMTk6MDU6MzcgMjAx MCAtMDcwMApAQCAtMjYsNyArMjYsNyBAQAogICAgICAgYmFzaD4gZ2RiIC4vdm1saW51eCAgICAg ICAgICAgICAoZXhhY3QgbWF0Y2hpbmcgdm1saW51eCBvZiBndWVzdCBrZXJuZWwpCiAgICAgICAo Z2RiKSB0YXJnZXQgcmVtb3RlIGRvbTA6OTk5OSAKIAotICAgLSBBZGRpdGlvbmFsbHksIHRvIGRl YnVnIGxvYWRhYmxlIGtlcm5lbCBtb2R1bGVzLCBwbGVhc2UgZG8gZm9sbG93aW5nOgorICAgLSBB ZGRpdGlvbmFsbHksIHRvIGRlYnVnIDMyYml0IGxvYWRhYmxlIGtlcm5lbCBtb2R1bGVzLCBwbGVh c2UgZG8gZm9sbG93aW5nOgogICAgICAgKGdkYikgcCBpbml0X21tLnBnZFszXQogICAgICAgJDEg PSB7cGdkID0gMHgxYjg3NGYwMjd9CiAgICAgICAoZ2RiKSBtb25pdG9yIHBnZDMgMHgxYjg3NGYw MjcgIChNYWtlIHN1cmUgdmFsdWUgaXMgaW4gSEVYKQpkaWZmIC1yIGQ4NjdlYjY0M2ZlNCB0b29s cy9kZWJ1Z2dlci9nZGJzeC9neC9neF9tYWluLmMKLS0tIGEvdG9vbHMvZGVidWdnZXIvZ2Ric3gv Z3gvZ3hfbWFpbi5jCVR1ZSBKdWwgMTMgMTg6MTc6MjggMjAxMCArMDEwMAorKysgYi90b29scy9k ZWJ1Z2dlci9nZGJzeC9neC9neF9tYWluLmMJV2VkIEp1bCAxNCAxOTowNTozNyAyMDEwIC0wNzAw CkBAIC0xMzIsMTIgKzEzMiwxMiBAQAogc3RhdGljIHZvaWQKIHByb2Nlc3NfcV9yZXF1ZXN0KGNo YXIgKnJlbW90ZV9idWYpCiB7Ci0gICAgLyogc2VuZCBhIGxpc3Qgb2YgdGlkczogIm0gMCwxLDIs M2wiICovCisgICAgLyogc2VuZCBhIGxpc3Qgb2YgdGlkczogIm0wLDEsMiwzbCIgKi8KICAgICBp ZiAoc3RyY21wKCJxZlRocmVhZEluZm8iLCByZW1vdGVfYnVmKSA9PSAwKSB7CiAgICAgICAgIHZj cHVpZF90IHZpZCA9IDA7CiAgICAgICAgIGNoYXIgKnAgPSByZW1vdGVfYnVmOwogCi0gICAgICAg IHNwcmludGYocCwgIm0gJXgiLCB2aWQpOyAgICAgICAgLyogcHV0cyBudWxsIGNoYXIgYXQgdGhl IGVuZCAqLworICAgICAgICBzcHJpbnRmKHAsICJtJXgiLCB2aWQpOyAgICAgICAgLyogcHV0cyBu dWxsIGNoYXIgYXQgdGhlIGVuZCAqLwogICAgICAgICBwID0gcCArIHN0cmxlbihwKTsKICAgICAg ICAgZm9yICh2aWQ9MTsgdmlkIDw9IG1heF92Y3B1aWQ7IHZpZCsrKSB7CiAgICAgICAgICAgICBz cHJpbnRmKHAsICIsJXgiLCB2aWQpOwpAQCAtMTQ2LDggKzE0Niw5IEBACiAgICAgICAgIHNwcmlu dGYocCwgImwiKTsgICAgICAgICAgICAgICAgLyogcHV0cyBudWxsIGNoYXIgYXQgdGhlIGVuZCAq LwogICAgICAgICByZXR1cm47CiAgICAgfQorCiAgICAgLyogcVN5bWJvbCB3b3JrcyBmb3IgaW5p dF9tbSwgYW5kIG5vdCBpbml0X21tLnBnZCwgaGVuY2Ugd2UgY2FuJ3QgdXNlCi0gICAgICAgICAq IGl0IGF0IHRoaXMgdGltZS4gaW5zdGVhZCB1c2UgIm1vbml0b3IiIGluIGdkYiAqLworICAgICAq IGl0IGF0IHRoaXMgdGltZS4gaW5zdGVhZCB1c2UgIm1vbml0b3IiIGluIGdkYiAqLwogICAgIGlm IChzdHJuY21wKCJxUmNtZCwiLCByZW1vdGVfYnVmLCA2KSA9PSAwKSB7CiAgICAgICAgIF9kb19x UmNtZF9yZXEocmVtb3RlX2J1Zik7CiAgICAgICAgIHJldHVybjsKQEAgLTE1NSw4ICsxNTYsNyBA QAogCiAgICAgLyogVEJEIDogcVRocmVhZEV4dHJhSW5mbyA6IHNlbmQgZXh0cmEgYmFubmVyIGlu Zm8gICovCiAKLSAgICAgICAgLyogbm90aGluZyBlbHNlIHN1cHBvcnRlZCByaWdodCBub3cgKi8K LSAgICByZW1vdGVfYnVmWzBdID0gJ1wwJzsKKyAgICByZW1vdGVfYnVmWzBdID0gJ1wwJzsgICAg ICAgICAgICAgIC8qIG5vdGhpbmcgZWxzZSBzdXBwb3J0ZWQgZm9yIG5vdyAqLwogCiAgICAgcmV0 dXJuOwogfQo= --MP_/ffcWk+1L2u5Wn9GIBlf1EQ9 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --MP_/ffcWk+1L2u5Wn9GIBlf1EQ9--