[PATCH] libxl: fix linking error

[PATCH] libxl: fix linking error

[Christoph Egger]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]


Hi!

Attached patch fixes linking error when creating the xl binary.
The xl binary compiles in xl_cmdimpl.c which calls code from
libxl_paths.c and libxl_bootloader.c.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_tools_libxl3.diff --]
[-- Type: text/x-diff, Size: 504 bytes --]

diff -r d607d892b568 tools/libxl/Makefile
--- a/tools/libxl/Makefile	Tue Jul 20 17:55:39 2010 +0200
+++ b/tools/libxl/Makefile	Tue Jul 20 18:21:59 2010 +0200
@@ -87,7 +87,7 @@ xl_cmdimpl.o: xl_cmdimpl.c
 xl_cmdtable.o: xl_cmdtable.c
 	$(CC) $(CFLAGS) -c xl_cmdtable.c
 
-$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so
+$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so
 	$(CC) $(LDFLAGS) -o $@ $^ $(LIBS)
 
 .PHONY: install

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] libxl: fix linking error

[Ian Jackson]

Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
> Attached patch fixes linking error when creating the xl binary.
> The xl binary compiles in xl_cmdimpl.c which calls code from
> libxl_paths.c and libxl_bootloader.c.
...
> -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so
> +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so

This can't possibly be right.  Files called "libxl_*.o" are parts of
libxl and should be in libxenlight.so.

I see, however, that Stefano has already applied it.

Ian.

Re: [PATCH] libxl: fix linking error

[Stefano Stabellini]

On Wed, 21 Jul 2010, Ian Jackson wrote:
> Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
> > Attached patch fixes linking error when creating the xl binary.
> > The xl binary compiles in xl_cmdimpl.c which calls code from
> > libxl_paths.c and libxl_bootloader.c.
> ...
> > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so libxenlight.so
> > +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so
> 
> This can't possibly be right.  Files called "libxl_*.o" are parts of
> libxl and should be in libxenlight.so.
> 
> I see, however, that Stefano has already applied it.
> 

Yes, sorry I missed it.

Re: [PATCH] libxl: fix linking error

[Christoph Egger]

On Wednesday 21 July 2010 18:14:14 Stefano Stabellini wrote:
> On Wed, 21 Jul 2010, Ian Jackson wrote:
> > Christoph Egger writes ("[Xen-devel] [PATCH] libxl: fix linking error"):
> > > Attached patch fixes linking error when creating the xl binary.
> > > The xl binary compiles in xl_cmdimpl.c which calls code from
> > > libxl_paths.c and libxl_bootloader.c.
> >
> > ...
> >
> > > -$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o libxlutil.so
> > > libxenlight.so +$(CLIENTS): xl.o xl_cmdimpl.o xl_cmdtable.o
> > > libxl_paths.o libxl_bootloader.o libxlutil.so libxenlight.so
> >
> > This can't possibly be right.  Files called "libxl_*.o" are parts of
> > libxl and should be in libxenlight.so.
> >
> > I see, however, that Stefano has already applied it.
>
> Yes, sorry I missed it.

I realized this patch is wrong. Please apply the patch to correct this:
http://lists.xensource.com/archives/html/xen-devel/2010-07/msg01068.html

Christoph

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632