From: Christoph Egger <Christoph.Egger@amd.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] libxl: move blktap-specific code into libxl_blktap.c
Date: Fri, 30 Jul 2010 10:40:27 +0200 [thread overview]
Message-ID: <201007301040.28331.Christoph.Egger@amd.com> (raw)
In-Reply-To: <19537.49697.129250.664039@mariner.uk.xensource.com>
On Thursday 29 July 2010 20:02:09 Ian Jackson wrote:
> Christoph Egger writes ("[PATCH] libxl: move blktap-specific code into
libxl_blktap.c"):
> > libxl: move blktap-specific code into libxl_blktap.c
>
> Except, once again, this is not _pure_ motion. You need to split the
> patch up so that, in the code motion patch,
>
> diff -u <(hg diff tools/libxl/libxl.c | perl -pe 's/^[-+]/ $& eq "-" ?
> "+" : "-" /e' ) <(hg diff tools/libxl/libxl_blktap.c)
>
> doesn't produce any substantive output.
I'm sorry, I don't know perl. And this command fails with syntax error: '('
unexpected.
I haven't send the patch yesterday. It was late for me.
You seem to respond always in the late afternoon (CEST).
In which timezone are you ?
Christoph
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
next prev parent reply other threads:[~2010-07-30 8:40 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 16:31 [PATCH] libxl: blktap2 portiblity fixes Christoph Egger
2010-07-20 16:46 ` Stefano Stabellini
2010-07-21 8:32 ` Christoph Egger
2010-07-23 12:30 ` Stefano Stabellini
2010-07-23 18:05 ` Ian Jackson
2010-07-26 10:56 ` Christoph Egger
2010-07-26 14:53 ` Ian Jackson
2010-07-26 15:00 ` Ian Campbell
2010-07-26 15:12 ` Ian Jackson
2010-07-26 16:01 ` Christoph Egger
2010-07-26 16:05 ` Christoph Egger
2010-07-26 16:36 ` Ian Jackson
2010-07-27 12:07 ` Christoph Egger
2010-07-27 12:15 ` [PATCH 1/6] libxl: " Christoph Egger
2010-07-27 12:16 ` [PATCH 2/6] " Christoph Egger
2010-07-27 12:17 ` [PATCH 3/6] " Christoph Egger
2010-07-27 12:18 ` [PATCH 4/6] " Christoph Egger
2010-07-27 12:20 ` [PATCH 5/6] " Christoph Egger
2010-07-27 12:21 ` [PATCH 6/6] " Christoph Egger
2010-07-27 17:00 ` [PATCH 5/6] " Ian Jackson
2010-07-28 9:17 ` Christoph Egger
2010-07-27 16:58 ` [PATCH 4/6] " Ian Jackson
2010-07-28 11:50 ` Christoph Egger
[not found] ` <19535.3166.214153.676101@mariner.uk.xensource.com>
2010-07-28 11:42 ` [PATCH] libxl: compile fix Christoph Egger
2010-07-28 12:22 ` Ian Campbell
2010-07-28 13:03 ` Christoph Egger
2010-07-27 16:34 ` [PATCH 2/6] libxl: portiblity fixes Ian Jackson
2010-07-28 9:06 ` Christoph Egger
2010-07-28 9:21 ` Keir Fraser
2010-07-28 9:30 ` Christoph Egger
2010-07-28 11:39 ` [PATCH] libxl: move blktap specific code into libxl_blktap.c Christoph Egger
2010-07-29 15:02 ` Ian Jackson
2010-07-29 15:08 ` Stefano Stabellini
2010-07-29 15:41 ` Christoph Egger
2010-07-29 15:46 ` Ian Jackson
2010-07-29 15:48 ` Ian Jackson
2010-07-29 16:46 ` [PATCH] libxl: move blktap-specific " Christoph Egger
2010-07-29 18:02 ` Ian Jackson
2010-07-30 8:40 ` Christoph Egger [this message]
2010-07-30 8:45 ` Christoph Egger
2010-07-27 16:31 ` [PATCH 1/6] libxl: portiblity fixes Ian Jackson
2010-07-28 9:49 ` Christoph Egger
2010-07-27 12:17 ` [PATCH 0/6] " Christoph Egger
2010-07-27 16:30 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201007301040.28331.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).