[PATCH] tools: Allow space in vbd path name

[PATCH] tools: Allow space in vbd path name

[Jim Fehlig]

[-- Attachment #1: Type: text/plain, Size: 48 bytes --]

Trivial fix for block script ...

Regards,
Jim


[-- Attachment #2: block-script.patch --]
[-- Type: text/x-patch, Size: 965 bytes --]

# HG changeset patch
# User Jim Fehlig <jfehlig@novell.com>
# Date 1274807602 21600
# Node ID 14d040342c6618365750b2c3b96ca01ff4a5e5dd
# Parent  93410e5e4ad8799932ad31820d0d82c74d1f63a2
Allow space in vbd path name

c/s 20393 breaks existing domain configuration that contains
spaces in the vbd path name.  Fixed by this trivial patch which
provides missing quotes.

    Signed-off-by: Jim Fehlig <jfehlig@novell.com>

diff -r 93410e5e4ad8 -r 14d040342c66 tools/hotplug/Linux/block
--- a/tools/hotplug/Linux/block	Sat May 22 06:36:41 2010 +0100
+++ b/tools/hotplug/Linux/block	Tue May 25 11:13:22 2010 -0600
@@ -272,8 +272,8 @@
 
         if [ "x$mode" != 'x!' ]
         then
-          inode=$(stat -c '%i' $file)
-          dev=$(stat -c '%D' $file)
+          inode=$(stat -c '%i' "$file")
+          dev=$(stat -c '%D' "$file")
           if [ -z "$inode" ] || [ -z "$dev" ]
           then
             fatal "Unable to lookup $file: dev: $dev inode: $inode"

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] tools: Allow space in vbd path name

[Pasi Kärkkäinen]

On Tue, May 25, 2010 at 11:15:48AM -0600, Jim Fehlig wrote:
> Trivial fix for block script ...
> 

Hello,

was this patch merged? There's an user on ##xen complaining about
vif devices not released if there's a typo on the vbd path..

I think he tried both xen 4.0 and 4.1-unstable.

-- Pasi

> Regards,
> Jim
> 

> # HG changeset patch
> # User Jim Fehlig <jfehlig@novell.com>
> # Date 1274807602 21600
> # Node ID 14d040342c6618365750b2c3b96ca01ff4a5e5dd
> # Parent  93410e5e4ad8799932ad31820d0d82c74d1f63a2
> Allow space in vbd path name
> 
> c/s 20393 breaks existing domain configuration that contains
> spaces in the vbd path name.  Fixed by this trivial patch which
> provides missing quotes.
> 
>     Signed-off-by: Jim Fehlig <jfehlig@novell.com>
> 
> diff -r 93410e5e4ad8 -r 14d040342c66 tools/hotplug/Linux/block
> --- a/tools/hotplug/Linux/block	Sat May 22 06:36:41 2010 +0100
> +++ b/tools/hotplug/Linux/block	Tue May 25 11:13:22 2010 -0600
> @@ -272,8 +272,8 @@
>  
>          if [ "x$mode" != 'x!' ]
>          then
> -          inode=$(stat -c '%i' $file)
> -          dev=$(stat -c '%D' $file)
> +          inode=$(stat -c '%i' "$file")
> +          dev=$(stat -c '%D' "$file")
>            if [ -z "$inode" ] || [ -z "$dev" ]
>            then
>              fatal "Unable to lookup $file: dev: $dev inode: $inode"

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

Re: [PATCH] tools: Allow space in vbd path name

[Jim Fehlig]

Pasi Kärkkäinen wrote:
> On Tue, May 25, 2010 at 11:15:48AM -0600, Jim Fehlig wrote:
>   
>> Trivial fix for block script ...
>>
>>     
>
> Hello,
>
> was this patch merged? There's an user on ##xen complaining about
> vif devices not released if there's a typo on the vbd path..
>   

Yes, as c/s 21459.

Jim