Re: [PATCH] Remus breaks the build

[Brendan Cully <brendan@cs.ubc.ca>]

On Thursday, 12 August 2010 at 17:38, Jeremy Fitzhardinge wrote:
>  Remus tries to go out of the tools directory and build in the kernel
> directory.  This assumes that we're actually building a kernel out of
> the xen build tree, and that kernel is actually being used.
> 
> If Remus needs kernel modules, they should actually be part of the
> respective kernel trees, not grafted on post-facto.
> 
> Disable the tools/remus directory until this is sorted out.
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

I assume you're talking about this snippet of tools/remus/kmod/Makefile:

$(MAKE) -C $(KERNELDIR) SUBDIRS=`pwd` modules

which expects to find a Makefile in $KERNELDIR but does the actual
building in place, in the tools/remus/kmod directory (unless the
kernel build system has changed recently?). I thought this was a
pretty standard way to build out-of-tree kernel modules.

I'm not sure why this is causing you problems (is it?), but if you're
willing to carry sch_queue in the pvops tree, I'd be happy to drop
tools/remus/kmod in the unstable tree.