From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Cully Subject: Re: [PATCH] Remus breaks the build Date: Fri, 13 Aug 2010 12:42:17 -0700 Message-ID: <20100813194217.GA6981@kremvax.cs.ubc.ca> References: <4C6493ED.3040605@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4C6493ED.3040605@goop.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge Cc: "Xen-devel@lists.xensource.com" , Ian Jackson , Ian Campbell , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On Thursday, 12 August 2010 at 17:38, Jeremy Fitzhardinge wrote: > Remus tries to go out of the tools directory and build in the kernel > directory. This assumes that we're actually building a kernel out of > the xen build tree, and that kernel is actually being used. > > If Remus needs kernel modules, they should actually be part of the > respective kernel trees, not grafted on post-facto. > > Disable the tools/remus directory until this is sorted out. > > Signed-off-by: Jeremy Fitzhardinge I assume you're talking about this snippet of tools/remus/kmod/Makefile: $(MAKE) -C $(KERNELDIR) SUBDIRS=`pwd` modules which expects to find a Makefile in $KERNELDIR but does the actual building in place, in the tools/remus/kmod directory (unless the kernel build system has changed recently?). I thought this was a pretty standard way to build out-of-tree kernel modules. I'm not sure why this is causing you problems (is it?), but if you're willing to carry sch_queue in the pvops tree, I'd be happy to drop tools/remus/kmod in the unstable tree.