xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Brendan Cully <brendan@cs.ubc.ca>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	"Xen-devel@lists.xensource.com" <Xen-devel@lists.xensource.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Stabellini <stefano.stabellini@eu.citrix.com>,
	Stefano@cs.ubc.ca, Dulloor <dulloor@gmail.com>
Subject: Re: Re: [PATCH] Remus breaks the build
Date: Wed, 18 Aug 2010 10:58:52 -0700	[thread overview]
Message-ID: <20100818175852.GB14363@kremvax.cs.ubc.ca> (raw)
In-Reply-To: <19563.58079.648445.441841@mariner.uk.xensource.com>

On Wednesday, 18 August 2010 at 14:40, Ian Jackson wrote:
> Brendan Cully writes ("Re: [Xen-devel] Re: [PATCH] Remus breaks the build"):
> > We need a second module (IFB or IMQ, depending on the kernel version)
> > because Linux queueing disciplines only operate on a device's outbound
> > traffic. Since Remus runs in dom0, it sees the guest's outbound
> > traffic as _inbound_ traffic on a VIF device. So IMQ/IFB is used to
> > redirect that incoming VIF traffic to a virtual intermediate device
> > with the sch_queue queueing discipline installed on it.
> 
> Couldn't this be achieved simply by putting a dummy bridge or tap
> device in the way or something ?  You seem to be describing a device
> driver whose sole purpose is plumbing ...

You are correct, the device is just plumbing. But it isn't any extra
code, at least for pvops -- IFB is carried in upstream linux. You
could probably use a second-level bridge or tap or policy routing or
something to get the same effect, but I don't think I see the
advantage. You're certainly welcome to put together an alternative
approach for comparison.

What would be simpler and more efficient would be to move the queueing
directly into netback. That's on the todo list but hasn't gotten
attention yet.

  reply	other threads:[~2010-08-18 17:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-13  0:38 [PATCH] Remus breaks the build Jeremy Fitzhardinge
2010-08-13 10:38 ` Ian Campbell
2010-08-13 11:55   ` Stefano Stabellini
2010-08-13 12:52     ` Ian Jackson
2010-08-13 19:44       ` Brendan Cully
2010-08-18 20:09         ` Brendan Cully
2010-08-13 19:42 ` Brendan Cully
2010-08-13 21:14   ` Jeremy Fitzhardinge
2010-08-14  4:25     ` Dulloor
2010-08-17 17:38       ` Brendan Cully
2010-08-18 13:40         ` Ian Jackson
2010-08-18 17:58           ` Brendan Cully [this message]
2010-08-19 14:38             ` Ian Jackson
2010-08-18 20:26     ` Brendan Cully
2010-08-18 20:34       ` Jed Smith
2010-08-18 20:39         ` Brendan Cully
2010-08-18 23:54       ` Jeremy Fitzhardinge
2010-08-19  0:03         ` Brendan Cully
2010-08-19  6:03           ` Pasi Kärkkäinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100818175852.GB14363@kremvax.cs.ubc.ca \
    --to=brendan@cs.ubc.ca \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=Stefano@cs.ubc.ca \
    --cc=Xen-devel@lists.xensource.com \
    --cc=dulloor@gmail.com \
    --cc=jeremy@goop.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).