From: Brendan Cully <brendan@kublai.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Xen
Subject: Re: Re: [PATCH] Remus breaks the build
Date: Wed, 18 Aug 2010 13:09:15 -0700 [thread overview]
Message-ID: <20100818200915.GB2411@kremvax.cs.ubc.ca> (raw)
In-Reply-To: <20100813194400.GB6981@kremvax.cs.ubc.ca>
On Friday, 13 August 2010 at 12:44, Brendan Cully wrote:
> On Friday, 13 August 2010 at 13:52, Ian Jackson wrote:
> > Stefano Stabellini writes ("[Xen-devel] Re: [PATCH] Remus breaks the build"):
> > > I'll apply the patch for now, of course I am more then willing to
> > > re-enable remus as soon as the problem is fixed.
> >
> > Quite so. I have also removed remus from the nightly tests (since
> > otherwise this would be regarded as a regression in the cases where
> > remus still sort of worked; it hasn't worked properly for some time).
>
> As always, Ian, it would be better if you provided some kind of
> concrete bug report instead vaguely saying "it doesn't work". I've
> never received one.
It turns out it was broken... by you, in 21488:dd6bbdc42033 (I missed
this because I've been running the 4.0 tree until recently). That
patch of yours only appeared to be a no-op, because it missed several
calls to read_exact. I've patchbombed the fix.
next prev parent reply other threads:[~2010-08-18 20:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-13 0:38 [PATCH] Remus breaks the build Jeremy Fitzhardinge
2010-08-13 10:38 ` Ian Campbell
2010-08-13 11:55 ` Stefano Stabellini
2010-08-13 12:52 ` Ian Jackson
2010-08-13 19:44 ` Brendan Cully
2010-08-18 20:09 ` Brendan Cully [this message]
2010-08-13 19:42 ` Brendan Cully
2010-08-13 21:14 ` Jeremy Fitzhardinge
2010-08-14 4:25 ` Dulloor
2010-08-17 17:38 ` Brendan Cully
2010-08-18 13:40 ` Ian Jackson
2010-08-18 17:58 ` Brendan Cully
2010-08-19 14:38 ` Ian Jackson
2010-08-18 20:26 ` Brendan Cully
2010-08-18 20:34 ` Jed Smith
2010-08-18 20:39 ` Brendan Cully
2010-08-18 23:54 ` Jeremy Fitzhardinge
2010-08-19 0:03 ` Brendan Cully
2010-08-19 6:03 ` Pasi Kärkkäinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100818200915.GB2411@kremvax.cs.ubc.ca \
--to=brendan@kublai.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=jeremy@goop.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).