From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brendan Cully Subject: Re: Re: [PATCH] Remus breaks the build Date: Wed, 18 Aug 2010 13:09:15 -0700 Message-ID: <20100818200915.GB2411@kremvax.cs.ubc.ca> References: <4C6493ED.3040605@goop.org> <1281695884.3170.676.camel@zakaz.uk.xensource.com> <19557.16422.38625.558018@mariner.uk.xensource.com> <20100813194400.GB6981@kremvax.cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100813194400.GB6981@kremvax.cs.ubc.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Stefano Stabellini , Ian Campbell , Jeremy Fitzhardinge , Xen List-Id: xen-devel@lists.xenproject.org On Friday, 13 August 2010 at 12:44, Brendan Cully wrote: > On Friday, 13 August 2010 at 13:52, Ian Jackson wrote: > > Stefano Stabellini writes ("[Xen-devel] Re: [PATCH] Remus breaks the build"): > > > I'll apply the patch for now, of course I am more then willing to > > > re-enable remus as soon as the problem is fixed. > > > > Quite so. I have also removed remus from the nightly tests (since > > otherwise this would be regarded as a regression in the cases where > > remus still sort of worked; it hasn't worked properly for some time). > > As always, Ian, it would be better if you provided some kind of > concrete bug report instead vaguely saying "it doesn't work". I've > never received one. It turns out it was broken... by you, in 21488:dd6bbdc42033 (I missed this because I've been running the 4.0 tree until recently). That patch of yours only appeared to be a no-op, because it missed several calls to read_exact. I've patchbombed the fix.