From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] xl: improve vif2 parsing
Date: Fri, 20 Aug 2010 16:28:07 +0200
Message-ID: <201008201628.08694.Christoph.Egger@amd.com>
References: <4C6E6E84.5020704@amd.com> <4C6E7BE4.6090605@amd.com>
	<1282311269.3731.55.camel@qabil.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1282311269.3731.55.camel@qabil.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
Cc: "Przywara, Andre" <Andre.Przywara@amd.com>, Keir Fraser <Keir.Fraser@eu.citrix.com>, Gianni Tedesco <gianni.tedesco@citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Friday 20 August 2010 15:34:29 Gianni Tedesco wrote:
> On Fri, 2010-08-20 at 13:58 +0100, Andre Przywara wrote:
> > Gianni Tedesco wrote:
> > > On Fri, 2010-08-20 at 13:03 +0100, Andre Przywara wrote:
> > >> Andre Przywara wrote:
> > >>> Hi,
> > >>>
> > >>> vif2 parsing relies on counted strncmp() statements. Replace this
> > >>> with a more robust automatic version.
> > >>
> > >> No, I didn't want to leave this as an exercise to the reader, I am
> > >> just spoiled by git send-email, so forgot to attach the patch. Sorry!
> > >>
> > >>> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
> > >
> > > Both patches look good to me.
> > >
> > >>> Regards,
> > >>> Andre.
> > >>>
> > >>> P.S. If you like this, I have seen at least two more instances of the
> > >>> same issue that could be improved this way.
> > >
> > > Can you say where?
> >
> > In main_networkattach() and main_network2attach().
>
> You should absolutely sort this out. So I had already done a cleanup for
> similar problem with PCI BDF's.

Yes and OS-dependent code still needs to be sorted out.

Christoph


-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632