From: Josip Rodin <joy@entuzijast.net>
To: xen-devel@lists.xensource.com
Subject: __supported_pte_mask |= _PAGE_IOMAP twice?
Date: Sun, 22 Aug 2010 14:06:36 +0200 [thread overview]
Message-ID: <20100822120636.GA32564@entuzijast.net> (raw)
Hi,
I don't really understand this, but in xen-2.6.36/dom0/core there's this:
% git diff 0c2b1aa4c31830d3b9a40061d1b5f6c8cd837d57 057e5006127460b11e03bf80227881c528b0590d
diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c
index 167ca78..0850bd6 100644
--- a/arch/x86/xen/enlighten.c
+++ b/arch/x86/xen/enlighten.c
@@ -1195,12 +1195,12 @@ asmlinkage void __init xen_start_kernel(void)
pgd = (pgd_t *)xen_start_info->pt_base;
- if (xen_initial_domain())
- __supported_pte_mask |= _PAGE_IOMAP;
- else
+ if (!xen_initial_domain())
__supported_pte_mask &= ~(_PAGE_PWT | _PAGE_PCD);
__supported_pte_mask |= _PAGE_IOMAP;
+
+ __supported_pte_mask |= _PAGE_IOMAP;
/* Don't do the full vcpu_info placement stuff until we have a
possible map and a non-dummy shared_info. */
per_cpu(xen_vcpu, 0) = &HYPERVISOR_shared_info->vcpu_info[0];
What's the point of doing the same thing twice at the end? Maybe it's
a mis-merge?
--
2. That which causes joy or happiness.
next reply other threads:[~2010-08-22 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-22 12:06 Josip Rodin [this message]
2010-08-22 12:13 ` __supported_pte_mask |= _PAGE_IOMAP twice? Josip Rodin
2010-08-22 13:07 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100822120636.GA32564@entuzijast.net \
--to=joy@entuzijast.net \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).