From: Olaf Hering <olaf@aepfle.de>
To: xen-devel@lists.xensource.com
Subject: Re: no cycles for certain xentrace entries
Date: Wed, 29 Sep 2010 10:09:29 +0200 [thread overview]
Message-ID: <20100929080929.GA24421@aepfle.de> (raw)
In-Reply-To: <20100831184458.GA24018@aepfle.de>
On Tue, Aug 31, Olaf Hering wrote:
> what is the reason for the empty tsc for some xentracing calls, like
> TRC_HVM_IOPORT_READ?
> It makes sorting the resulting logfile by tsc value difficult because
> the 0 entries end up at the beginning of the logfile.
This change appears to work for me.
So, what is the reason for the cycles parameter to trace_var()?
--- xen-4.0.1-testing.orig/xen/common/trace.c
+++ xen-4.0.1-testing/xen/common/trace.c
@@ -631,6 +631,7 @@ void __trace_var(u32 event, bool_t cycle
if( !tb_init_done )
return;
+ cycles = 1;
/* Convert byte count into word count, rounding up */
extra_word = (extra / sizeof(u32));
if ( (extra % sizeof(u32)) != 0 )
next prev parent reply other threads:[~2010-09-29 8:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 18:44 no cycles for certain xentrace entries Olaf Hering
2010-09-29 8:09 ` Olaf Hering [this message]
2010-09-30 9:56 ` George Dunlap
2010-09-30 14:18 ` Olaf Hering
2010-09-30 14:21 ` George Dunlap
2010-09-30 14:47 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100929080929.GA24421@aepfle.de \
--to=olaf@aepfle.de \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).