Re: [PATCH] pvops: fix "xm save -c" issue

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote:
> Hi,
> 
> I'm investigating the issue of "xm save -c" in case of PV guests.
> Then, I tried to prevent calling dpm_resume_end() when suspend was
> canceled. It seems to work fine about blk and net.
> How about this?


Could you give more details of what the failure is?

> 
> Thanks,
> 
> Signed-off-by: Kenji Wakamiya <wkenji@jp.fujitsu.com>
> Signed-off-by: Kazuhiro Suzuki <kaz@jp.fujitsu.com>
> -- 
> Kenji Wakamiya
> 

> diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
> index 0b50906..3dcc270 100644
> --- a/drivers/xen/manage.c
> +++ b/drivers/xen/manage.c
> @@ -148,11 +148,10 @@ out_resume:
>  	if (!cancelled) {
>  		xen_arch_resume();
>  		xs_resume();
> +		dpm_resume_end(PMSG_RESUME);
>  	} else
>  		xs_suspend_cancel();
>  
> -	dpm_resume_end(PMSG_RESUME);
> -
>  	/* Make sure timer events get retriggered on all CPUs */
>  	clock_was_set();
>  

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel