From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] pvops: fix "xm save -c" issue Date: Tue, 14 Dec 2010 09:59:25 -0500 Message-ID: <20101214145925.GA5769@dumpdata.com> References: <4D070138.7090708@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4D070138.7090708@jp.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Kenji Wakamiya Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote: > Hi, > > I'm investigating the issue of "xm save -c" in case of PV guests. > Then, I tried to prevent calling dpm_resume_end() when suspend was > canceled. It seems to work fine about blk and net. > How about this? Could you give more details of what the failure is? > > Thanks, > > Signed-off-by: Kenji Wakamiya > Signed-off-by: Kazuhiro Suzuki > -- > Kenji Wakamiya > > diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c > index 0b50906..3dcc270 100644 > --- a/drivers/xen/manage.c > +++ b/drivers/xen/manage.c > @@ -148,11 +148,10 @@ out_resume: > if (!cancelled) { > xen_arch_resume(); > xs_resume(); > + dpm_resume_end(PMSG_RESUME); > } else > xs_suspend_cancel(); > > - dpm_resume_end(PMSG_RESUME); > - > /* Make sure timer events get retriggered on all CPUs */ > clock_was_set(); > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xensource.com > http://lists.xensource.com/xen-devel