Re: [PATCH] pvops: fix "xm save -c" issue

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Dec 15, 2010 at 01:18:06PM +0900, Kenji Wakamiya wrote:
> Hi Konrad, thank you for your response,
> 
> Konrad Rzeszutek Wilk wrote:
> >On Tue, Dec 14, 2010 at 02:31:36PM +0900, Kenji Wakamiya wrote:
> >>Hi,
> >>
> >>I'm investigating the issue of "xm save -c" in case of PV guests.
> >>Then, I tried to prevent calling dpm_resume_end() when suspend was
> >>canceled. It seems to work fine about blk and net.
> >>How about this?
> >
> >
> >Could you give more details of what the failure is?
> 
> "xm save -c" saves domain state to storage and leaves it running after
> creating snapshot. When this command is executed for a pvops
> guest (xen/stable-2.6.32.x), the guest will hang up after accessing to
> devices.
> 
> When the guest is unapused, stop_machine() in manage.c returns as the
> suspend is cancelled. In that case, I think dpm_resume_end() should
> not be called after stop_machine().
> 
> I tested vbd and net, the guest did not hang.

OK. Does 'xm save' (so no -c) and then resume work with this patch
(I would think so, but I am curious whether you tested this).

> But I'm not sure if this is a right way...

Looks OK to me, just want to make sure that the normal 'xm save' still
works after this.