From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Paul Durrant <Paul.Durrant@citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] patch fix-rx-packets-accounting
Date: Thu, 16 Dec 2010 10:06:55 -0500 [thread overview]
Message-ID: <20101216150654.GA10123@dumpdata.com> (raw)
In-Reply-To: <291EDFCB1E9E224A99088639C47620228CF938AA7D@LONPMAILBOX01.citrite.net>
On Thu, Dec 16, 2010 at 11:49:04AM +0000, Paul Durrant wrote:
> No, I don't think so. The stats should be bumped on data ingress to the shared ring. After all, if this were ethernet, you generally have no way of knowing whether the packet you send ever makes it to its destination.
>
OK. Thanks.
> Paul
>
> > -----Original Message-----
> > From: Ian Campbell
> > Sent: 16 December 2010 11:45
> > To: Paul Durrant
> > Cc: Konrad Rzeszutek Wilk; xen-devel@lists.xensource.com
> > Subject: RE: [Xen-devel] [PATCH] patch fix-rx-packets-accounting
> >
> > On Thu, 2010-12-16 at 11:37 +0000, Paul Durrant wrote:
> > > I think tx_packets and tx_bytes accounting is ok. Do you think
> > they are wrong?
> >
> > I wonder if it might be more correct to only increment them if
> > status ==
> > NETIF_RSP_OK?
> >
> > Ian.
> >
>
prev parent reply other threads:[~2010-12-16 15:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-14 17:37 [PATCH] patch fix-PKT_PROT_LEN Paul Durrant
2010-12-14 17:38 ` [PATCH] patch fix-rx-packets-accounting Paul Durrant
2010-12-14 17:38 ` [PATCH] patch remove-timeout Paul Durrant
2010-12-14 17:38 ` [PATCH] patch fix-tx-work-todo Paul Durrant
2010-12-14 17:38 ` [PATCH] patch move-pending-tx-copy Paul Durrant
2010-12-15 15:45 ` [PATCH] patch remove-timeout Konrad Rzeszutek Wilk
2010-12-15 15:45 ` [PATCH] patch fix-rx-packets-accounting Konrad Rzeszutek Wilk
2010-12-16 11:37 ` Paul Durrant
2010-12-16 11:44 ` Ian Campbell
2010-12-16 11:49 ` Paul Durrant
2010-12-16 15:06 ` Konrad Rzeszutek Wilk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101216150654.GA10123@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).