From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] patch fix-rx-packets-accounting Date: Thu, 16 Dec 2010 10:06:55 -0500 Message-ID: <20101216150654.GA10123@dumpdata.com> References: <1292348283-5786-1-git-send-email-paul.durrant@citrix.com> <1292348283-5786-2-git-send-email-paul.durrant@citrix.com> <20101215154505.GD28984@dumpdata.com> <291EDFCB1E9E224A99088639C47620228CF938AA71@LONPMAILBOX01.citrite.net> <1292499886.32368.7420.camel@zakaz.uk.xensource.com> <291EDFCB1E9E224A99088639C47620228CF938AA7D@LONPMAILBOX01.citrite.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <291EDFCB1E9E224A99088639C47620228CF938AA7D@LONPMAILBOX01.citrite.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Paul Durrant Cc: Ian Campbell , "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On Thu, Dec 16, 2010 at 11:49:04AM +0000, Paul Durrant wrote: > No, I don't think so. The stats should be bumped on data ingress to the shared ring. After all, if this were ethernet, you generally have no way of knowing whether the packet you send ever makes it to its destination. > OK. Thanks. > Paul > > > -----Original Message----- > > From: Ian Campbell > > Sent: 16 December 2010 11:45 > > To: Paul Durrant > > Cc: Konrad Rzeszutek Wilk; xen-devel@lists.xensource.com > > Subject: RE: [Xen-devel] [PATCH] patch fix-rx-packets-accounting > > > > On Thu, 2010-12-16 at 11:37 +0000, Paul Durrant wrote: > > > I think tx_packets and tx_bytes accounting is ok. Do you think > > they are wrong? > > > > I wonder if it might be more correct to only increment them if > > status == > > NETIF_RSP_OK? > > > > Ian. > > >