From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <Christoph.Egger@amd.com>
Subject: Re: [PATCH] vtdt: add a missing change (RE: Re: xen guest
	hang with TSC_DEADLINE)
Date: Tue, 4 Jan 2011 12:00:21 +0100
Message-ID: <201101041200.22612.Christoph.Egger@amd.com>
References: <201012171529.56897.Christoph.Egger@amd.com>
	<201012201518.04667.Christoph.Egger@amd.com>
	<F26D193E20BBDC42A43B611D1BDEDE7124EF2BCFA3@shsmsx502.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-15"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <F26D193E20BBDC42A43B611D1BDEDE7124EF2BCFA3@shsmsx502.ccr.corp.intel.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: "Wei, Gang" <gang.wei@intel.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Morgan,
	KeirX" <keirx.morgan@intel.com>, Fraser <Keir.Fraser@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On Monday 27 December 2010 04:05:41 Wei, Gang wrote:
> Christoph Egger wrote on=A02010-12-20:
> >>> c/s 22529 and 22530 cause a xen guest hang.
> >>>
> >>> While "normal" guests like Linux and NetBSD boot fine I boot Xen
> >>> itself as a xen guest for my nested virtualization.
> >>>
> >>> When I do that then the guest dom0 hangs at boot when it tries to
> >>> initialize the first vcpu.
> >>> The bug is introduced somewhere in c/s 22529 and triggers with c/s
> >>> 22530.
> >>
> >> Can you enable apic_timer debug info var hvm_debug and give more
> >> serial port log around the guest dom0 hangs? I used to test xen
> >> guest, it works well expect that it boot a little bit slowly.
> >
> > This is the log output I get with TSC_DEADLINE feature enabled:
>
> Just found one change was missed while the whole patch was checked in.
> Apply below patch, it should be ok now.
>
> diff -r 0133cf2a72f5 xen/arch/x86/hvm/vlapic.c
> --- a/xen/arch/x86/hvm/vlapic.c	Fri Dec 24 10:56:29 2010 +0000
> +++ b/xen/arch/x86/hvm/vlapic.c	Tue Dec 28 16:53:06 2010 +0800
> @@ -56,7 +56,7 @@ static unsigned int vlapic_lvt_mask[VLAP
>  static unsigned int vlapic_lvt_mask[VLAPIC_LVT_NUM] =3D
>  {
>       /* LVTT */
> -     LVT_MASK | APIC_TIMER_MODE_PERIODIC,
> +     LVT_MASK | APIC_TIMER_MODE_MASK,
>       /* LVTTHMR */
>       LVT_MASK | APIC_MODE_MASK,
>       /* LVTPC */
>
> Jimmy

The hang is still reproducable with this change. Sorry.

Christoph


=2D-=20
=2D--to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632