From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH 2/7] xen-gntdev: Change page limit to be global instead of per-open
Date: Mon, 10 Jan 2011 16:52:45 -0500 [thread overview]
Message-ID: <20110110215245.GD15016@dumpdata.com> (raw)
In-Reply-To: <1292545063-32107-3-git-send-email-dgdegra@tycho.nsa.gov>
> static long gntdev_ioctl(struct file *flip,
> unsigned int cmd, unsigned long arg)
> {
> @@ -555,9 +538,6 @@ static long gntdev_ioctl(struct file *flip,
> case IOCTL_GNTDEV_GET_OFFSET_FOR_VADDR:
> return gntdev_ioctl_get_offset_for_vaddr(priv, ptr);
>
> - case IOCTL_GNTDEV_SET_MAX_GRANTS:
> - return gntdev_ioctl_set_max_grants(priv, ptr);
Would it make sense to return -EPNOTSUPPORTED? Or does it not really
matter as nobody has been using this ioctl call?
> -
> default:
> if (debug)
> printk("%s: priv %p, unknown cmd %x\n",
> --
> 1.7.2.3
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
next prev parent reply other threads:[~2011-01-10 21:52 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 0:17 [PATCH v3] Userspace grant communication Daniel De Graaf
2010-12-17 0:17 ` [PATCH 1/7] xen-gntdev: Fix circular locking dependency Daniel De Graaf
2010-12-17 0:17 ` [PATCH 2/7] xen-gntdev: Change page limit to be global instead of per-open Daniel De Graaf
2011-01-10 21:52 ` Konrad Rzeszutek Wilk [this message]
2011-01-11 12:45 ` Daniel De Graaf
2011-01-11 17:51 ` Konrad Rzeszutek Wilk
2011-01-11 18:18 ` Daniel De Graaf
2011-01-11 18:21 ` Konrad Rzeszutek Wilk
2011-01-11 18:49 ` [PATCH libxc] Remove set_max_grants in linux Daniel De Graaf
2011-01-12 17:17 ` Ian Jackson
2011-01-12 17:57 ` Daniel De Graaf
2011-01-13 12:09 ` Ian Jackson
2011-01-13 12:48 ` Daniel De Graaf
2011-01-17 17:29 ` Ian Jackson
2010-12-17 0:17 ` [PATCH 3/7] xen-gntdev: Remove unneeded structures from grant_map tracking data Daniel De Graaf
2011-01-10 22:14 ` Konrad Rzeszutek Wilk
2011-01-11 13:02 ` Daniel De Graaf
2010-12-17 0:17 ` [PATCH 4/7] xen-gntdev: Use find_vma rather than iterating our vma list manually Daniel De Graaf
2010-12-17 0:17 ` [PATCH 5/7] xen-gntdev: Add reference counting to maps Daniel De Graaf
2010-12-17 0:49 ` Jeremy Fitzhardinge
2010-12-17 15:11 ` Daniel De Graaf
2010-12-17 0:51 ` Jeremy Fitzhardinge
2010-12-17 15:22 ` [PATCH 5/7 v2] " Daniel De Graaf
2011-01-10 22:28 ` Konrad Rzeszutek Wilk
2011-01-10 22:24 ` [PATCH 5/7] " Konrad Rzeszutek Wilk
2011-01-11 11:10 ` Stefano Stabellini
2011-01-11 17:46 ` Konrad Rzeszutek Wilk
2011-01-12 11:58 ` Stefano Stabellini
2010-12-17 0:17 ` [PATCH 6/7] xen-gntdev: Support mapping in HVM domains Daniel De Graaf
2010-12-17 15:22 ` [PATCH 6/7 v2] " Daniel De Graaf
2011-01-10 22:41 ` [PATCH 6/7] " Konrad Rzeszutek Wilk
2011-01-11 13:15 ` Daniel De Graaf
2011-01-11 14:52 ` Daniel De Graaf
2011-01-11 18:00 ` c/s 22402 ("86 hvm: Refuse to perform __hvm_copy() work in atomic context.") breaks HVM, race possible in other code - any ideas? Konrad Rzeszutek Wilk
2011-01-11 18:24 ` Daniel De Graaf
2010-12-17 0:17 ` [PATCH 7/7] xen-gntalloc: Userspace grant allocation driver Daniel De Graaf
2011-01-07 11:56 ` [PATCH v3] Userspace grant communication Stefano Stabellini
2011-01-14 15:18 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110110215245.GD15016@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).