From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
M A Young <m.a.young@durham.ac.uk>
Subject: Re: Crash on boot with 2.6.37-rc8-git3
Date: Tue, 25 Jan 2011 10:52:01 -0500 [thread overview]
Message-ID: <20110125155201.GA25076@dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1101251502540.7277@kaball-desktop>
On Tue, Jan 25, 2011 at 03:19:22PM +0000, Stefano Stabellini wrote:
> On Tue, 25 Jan 2011, Ian Campbell wrote:
> > > unless I am very confused
> > >
> > > map[i].size -= (map[i].size + map[i].addr) % PAGE_SIZE
> > >
> > > is not the same as:
> > >
> > > as map[i].size &= ~(PAGE_SIZE-1):
> > >
> > > because it also takes into account the possibility that map[i].addr is
> > > not page aligned.
> >
> > Oh yes, I didn't notice that aspect of it.
> >
> > > It doesn't move map[i].addr upward but still makes sure that
> > > the region ends at a page boundary anyway.
> >
> > Which returns to my second question ;-) Why do we not need to align addr
> > too?
>
> My machine can boot fine with a map[i].addr not page aligned.
OK, so then the patch that M A Young came up with ought to do it?
next prev parent reply other threads:[~2011-01-25 15:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:34 Crash on boot with 2.6.37-rc8-git3 M A Young
2011-01-07 21:23 ` Konrad Rzeszutek Wilk
2011-01-08 0:10 ` M A Young
2011-01-10 18:42 ` Konrad Rzeszutek Wilk
2011-01-10 21:43 ` M A Young
2011-01-16 20:48 ` M A Young
2011-01-16 20:56 ` Keir Fraser
2011-01-18 0:52 ` M A Young
2011-01-19 22:54 ` M A Young
2011-01-20 19:24 ` Konrad Rzeszutek Wilk
2011-01-20 22:39 ` M A Young
2011-01-21 15:27 ` Konrad Rzeszutek Wilk
2011-01-21 21:43 ` M A Young
2011-01-24 14:14 ` Konrad Rzeszutek Wilk
2011-01-24 23:12 ` M A Young
2011-01-25 12:03 ` Stefano Stabellini
2011-01-25 13:24 ` Ian Campbell
2011-01-25 13:31 ` Stefano Stabellini
2011-01-25 13:45 ` Ian Campbell
2011-01-25 15:19 ` Stefano Stabellini
2011-01-25 15:52 ` Konrad Rzeszutek Wilk [this message]
2011-01-25 15:56 ` Stefano Stabellini
2011-01-25 16:05 ` M A Young
2011-01-24 19:04 ` Stefano Stabellini
2011-01-25 0:22 ` M A Young
-- strict thread matches above, loose matches on Subject: below --
2011-01-04 22:01 M A Young
2011-01-05 15:43 ` Konrad Rzeszutek Wilk
2011-01-05 23:11 ` M A Young
2011-01-06 14:56 ` Konrad Rzeszutek Wilk
2011-01-07 0:37 ` M A Young
2011-01-07 19:18 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110125155201.GA25076@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=m.a.young@durham.ac.uk \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).