From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: Crash on boot with 2.6.37-rc8-git3
Date: Tue, 25 Jan 2011 10:52:01 -0500
Message-ID: <20110125155201.GA25076@dumpdata.com>
References: <alpine.LFD.2.02.1101202223370.13928@vega2.dur.ac.uk>
	<20110121152751.GA4156@dumpdata.com>
	<alpine.LFD.2.02.1101212024460.7991@vega1.dur.ac.uk>
	<20110124141453.GA6511@dumpdata.com>
	<alpine.LFD.2.02.1101242309450.20626@vega3.dur.ac.uk>
	<alpine.DEB.2.00.1101251152330.7277@kaball-desktop>
	<1295961878.14780.6063.camel@zakaz.uk.xensource.com>
	<alpine.DEB.2.00.1101251328010.7277@kaball-desktop>
	<1295963130.14780.6105.camel@zakaz.uk.xensource.com>
	<alpine.DEB.2.00.1101251502540.7277@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.00.1101251502540.7277@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, M A Young <m.a.young@durham.ac.uk>
List-Id: xen-devel@lists.xenproject.org

On Tue, Jan 25, 2011 at 03:19:22PM +0000, Stefano Stabellini wrote:
> On Tue, 25 Jan 2011, Ian Campbell wrote:
> > > unless I am very confused
> > > 
> > > map[i].size -= (map[i].size + map[i].addr) % PAGE_SIZE
> > > 
> > > is not the same as:
> > > 
> > > as map[i].size &= ~(PAGE_SIZE-1): 
> > > 
> > > because it also takes into account the possibility that map[i].addr is
> > > not page aligned.
> > 
> > Oh yes, I didn't notice that aspect of it.
> > 
> > >  It doesn't move map[i].addr upward but still makes sure that
> > > the region ends at a page boundary anyway.
> > 
> > Which returns to my second question ;-) Why do we not need to align addr
> > too?
> 
> My machine can boot fine with a map[i].addr not page aligned.

OK, so then the patch that M A Young came up with ought to do it?