From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Cc: jeremy@goop.org, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH] xen-gntdev: Fix unmap notify on PV domains
Date: Tue, 8 Feb 2011 17:58:56 -0500 [thread overview]
Message-ID: <20110208225856.GA9714@dumpdata.com> (raw)
In-Reply-To: <4D514FAE.4000709@tycho.nsa.gov>
On Tue, Feb 08, 2011 at 09:14:06AM -0500, Daniel De Graaf wrote:
> In paravirtualized guests, the struct page* for mappings is only a
> placeholder, and cannot be used to access the granted memory. Use the
> userspace mapping that we have set up in order to implement
> UNMAP_NOTIFY_CLEAR_BYTE.
>
> Signed-off-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
>
> diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> index 06de2c0..2b67f15 100644
> --- a/drivers/xen/gntdev.c
> +++ b/drivers/xen/gntdev.c
> @@ -287,7 +287,12 @@ static int unmap_grant_pages(struct grant_map *map, int offset, int pages)
>
> if (map->notify.flags & UNMAP_NOTIFY_CLEAR_BYTE) {
> int pgno = (map->notify.addr >> PAGE_SHIFT);
> - if (pgno >= offset && pgno < offset + pages) {
> + if (pgno >= offset && pgno < offset + pages && use_ptemod) {
> + void __user *tmp;
> + tmp = map->vma->vm_start + map->notify.addr;
> + copy_to_user(tmp, &err, 1);
The compiler really hates that. You could use a uninitialized_value macro
to ignore it.
> + map->notify.flags &= ~UNMAP_NOTIFY_CLEAR_BYTE;
> + } else if (pgno >= offset && pgno < offset + pages) {
> uint8_t *tmp = kmap(map->pages[pgno]);
> tmp[map->notify.addr & (PAGE_SIZE-1)] = 0;
> kunmap(map->pages[pgno]);
> @@ -296,7 +301,7 @@ static int unmap_grant_pages(struct grant_map *map, int offset, int pages)
> }
>
> pr_debug("map %d+%d [%d+%d]\n", map->index, map->count, offset, pages);
> - err = gnttab_unmap_refs(map->unmap_ops + offset, map->pages, pages);
> + err = gnttab_unmap_refs(map->unmap_ops + offset, map->pages + offset, pages);
> if (err)
> return err;
>
next prev parent reply other threads:[~2011-02-08 22:58 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-03 17:18 [PATCH v6] Userspace grant communication Daniel De Graaf
2011-02-03 17:18 ` [PATCH 1/6] xen-gntdev: Change page limit to be global instead of per-open Daniel De Graaf
2011-02-03 17:19 ` [PATCH 2/6] xen-gntdev: Use find_vma rather than iterating our vma list manually Daniel De Graaf
2011-02-03 17:19 ` [PATCH 3/6] xen-gntdev: Add reference counting to maps Daniel De Graaf
2011-02-03 17:19 ` [PATCH 4/6] xen-gntdev: Support mapping in HVM domains Daniel De Graaf
2011-02-14 15:51 ` Konrad Rzeszutek Wilk
2011-02-14 17:43 ` Daniel De Graaf
2011-02-14 18:52 ` Konrad Rzeszutek Wilk
2011-02-03 17:19 ` [PATCH 5/6] xen-gntalloc: Userspace grant allocation driver Daniel De Graaf
2011-02-08 22:48 ` Konrad Rzeszutek Wilk
2011-02-09 18:52 ` Daniel De Graaf
2011-02-03 17:19 ` [PATCH 6/6] xen/gntalloc, gntdev: Add unmap notify ioctl Daniel De Graaf
2011-02-14 15:37 ` Konrad Rzeszutek Wilk
2011-02-14 18:07 ` Daniel De Graaf
2011-02-03 19:16 ` [PATCH] xen-gntdev: Fix memory leak when mmap fails Daniel De Graaf
2011-02-07 23:14 ` [PATCH v6] Userspace grant communication Konrad Rzeszutek Wilk
2011-02-08 14:14 ` [PATCH] xen-gntdev: Fix unmap notify on PV domains Daniel De Graaf
2011-02-08 22:58 ` Konrad Rzeszutek Wilk [this message]
2011-02-09 20:33 ` [PATCH] xen-gntdev: prevent using UNMAP_NOTIFY_CLEAR_BYTE on read-only mappings Daniel De Graaf
2011-02-09 21:09 ` [PATCH v2] " Daniel De Graaf
2011-02-09 22:22 ` [PATCH] " Jeremy Fitzhardinge
2011-02-09 23:11 ` Daniel De Graaf
2011-02-09 23:15 ` [PATCH v3] " Daniel De Graaf
2011-02-08 21:49 ` [PATCH v6] Userspace grant communication Konrad Rzeszutek Wilk
2011-02-09 20:11 ` [PATCH] xen-gntdev: Use map->vma for checking map validity Daniel De Graaf
2011-02-09 20:12 ` [PATCH] xen-gntdev: Avoid unmapping ranges twice Daniel De Graaf
2011-02-09 21:11 ` [PATCH] xen-gntdev: Avoid double-mapping memory Daniel De Graaf
2011-02-14 16:14 ` [PATCH v6] Userspace grant communication Konrad Rzeszutek Wilk
2011-02-14 16:38 ` Konrad Rzeszutek Wilk
2011-02-14 17:56 ` Daniel De Graaf
2011-02-14 19:21 ` Konrad Rzeszutek Wilk
2011-02-14 20:55 ` Daniel De Graaf
2011-02-14 17:55 ` Daniel De Graaf
2011-02-14 19:04 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110208225856.GA9714@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=jeremy@goop.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).