From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-pm@lists.linux-foundation.org,
xen-devel@lists.xensource.com,
Iam Campbell <ian.campbell@citrix.com>,
Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt
Date: Tue, 22 Feb 2011 17:36:38 -0500 [thread overview]
Message-ID: <20110222223638.GA1341@dumpdata.com> (raw)
In-Reply-To: <AANLkTikrUUG92vQS_ZkdKCZ_+1BahQfAhRB-=8eNNW2o@mail.gmail.com>
> > Could we just make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_HIBERANTION?
> > Like this:
> >
> >
> > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > index 5b54892..838e20c 100644
> > --- a/arch/x86/xen/Kconfig
> > +++ b/arch/x86/xen/Kconfig
> > @@ -38,7 +38,7 @@ config XEN_MAX_DOMAIN_MEMORY
> >
> > config XEN_SAVE_RESTORE
> > bool
> > - depends on XEN && PM
> > + depends on XEN && PM && HIBERNATION
> > default y
> >
> > config XEN_DEBUG_FS
> >
> >
> On that aspect, just noticed
> config PM_SLEEP
> bool
> depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE
> default y
> we could get rid of XEN_SAVE_RESTORE as the suspend/resume code doesnt
> depend on PM_SLEEP
OK. Do you want to respin patch #2 without the #ifdefs in the drivers/base/...
and provide a new patch (#4?) which will alter the Kconfig file appropriately?
next prev parent reply other threads:[~2011-02-22 22:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-19 23:12 [PATCH 0/3] xen: Use PM/Hibernate events for save/restore/chkpt Shriram Rajagopalan
2011-02-19 23:12 ` [PATCH 1/3] xen: xenbus PM events support Shriram Rajagopalan
2011-02-19 23:12 ` [PATCH 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt Shriram Rajagopalan
2011-02-22 20:43 ` Konrad Rzeszutek Wilk
2011-02-22 21:14 ` Rafael J. Wysocki
2011-02-22 22:09 ` Shriram Rajagopalan
2011-02-22 22:35 ` Rafael J. Wysocki
2011-02-22 22:36 ` Konrad Rzeszutek Wilk [this message]
2011-02-22 22:53 ` Shriram Rajagopalan
2011-02-19 23:12 ` [PATCH 3/3] PM: pm.h - Add comments about Xen save/restore/chkpt use case Shriram Rajagopalan
2011-02-20 7:49 ` [PATCH 0/3] xen: Use PM/Hibernate events for save/restore/chkpt Pavel Machek
2011-02-21 10:05 ` Ian Campbell
2011-02-21 16:40 ` [linux-pm] " Alan Stern
2011-02-21 17:17 ` Ian Campbell
2011-02-21 20:23 ` Rafael J. Wysocki
2011-02-25 16:17 ` Stefano Stabellini
2011-02-25 16:19 ` Ian Campbell
2011-02-25 16:23 ` Stefano Stabellini
2011-02-23 18:38 ` Pavel Machek
2011-02-23 20:10 ` Rafael J. Wysocki
2011-02-24 16:13 ` Konrad Rzeszutek Wilk
2011-02-24 18:41 ` Rafael J. Wysocki
2011-02-25 17:19 ` Stefano Stabellini
2011-02-25 18:24 ` Rafael J. Wysocki
2011-02-28 11:06 ` [Xen-devel] " Stefano Stabellini
2011-03-04 16:04 ` Shriram Rajagopalan
2011-03-04 20:52 ` Rafael J. Wysocki
2011-02-23 7:03 ` [PATCH v2 2/3] xen: use freeze/restore/thaw PM events for suspend/resume/chkpt Shriram Rajagopalan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110222223638.GA1341@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=ian.campbell@citrix.com \
--cc=linux-pm@lists.linux-foundation.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=rshriram@cs.ubc.ca \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).