From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 2/3] xen: use freeze/restore/thaw PM events
	for suspend/resume/chkpt
Date: Tue, 22 Feb 2011 17:36:38 -0500
Message-ID: <20110222223638.GA1341@dumpdata.com>
References: <1298157158-5421-1-git-send-email-rshriram@cs.ubc.ca>
	<1298157158-5421-3-git-send-email-rshriram@cs.ubc.ca>
	<20110222204320.GB4605@dumpdata.com>
	<AANLkTikrUUG92vQS_ZkdKCZ_+1BahQfAhRB-=8eNNW2o@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <AANLkTikrUUG92vQS_ZkdKCZ_+1BahQfAhRB-=8eNNW2o@mail.gmail.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-pm@lists.linux-foundation.org, xen-devel@lists.xensource.com, Iam Campbell <ian.campbell@citrix.com>, Pavel Machek <pavel@ucw.cz>
List-Id: xen-devel@lists.xenproject.org

> > Could we just make CONFIG_XEN_SAVE_RESTORE depend on CONFIG_HIBERANTI=
ON?
> > Like this:
> >
> >
> > diff --git a/arch/x86/xen/Kconfig b/arch/x86/xen/Kconfig
> > index 5b54892..838e20c 100644
> > --- a/arch/x86/xen/Kconfig
> > +++ b/arch/x86/xen/Kconfig
> > @@ -38,7 +38,7 @@ config XEN_MAX_DOMAIN_MEMORY
> >
> > =A0config XEN_SAVE_RESTORE
> > =A0 =A0 =A0 =A0bool
> > - =A0 =A0 =A0 depends on XEN && PM
> > + =A0 =A0 =A0 depends on XEN && PM && HIBERNATION
> > =A0 =A0 =A0 =A0default y
> >
> > =A0config XEN_DEBUG_FS
> >
> >
> On that aspect, just noticed
> config PM_SLEEP
>         bool
>         depends on SUSPEND || HIBERNATION || XEN_SAVE_RESTORE
>         default y
> we could get rid of XEN_SAVE_RESTORE as the suspend/resume code doesnt
> depend on PM_SLEEP

OK. Do you want to respin patch #2 without the #ifdefs in the drivers/bas=
e/...
and provide a new patch (#4?) which will alter the Kconfig file appropria=
tely?