From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Shriram Rajagopalan <rshriram@cs.ubc.ca>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Frank Pan <frankpzh@gmail.com>,
Jeremy Fitzhardinge <Jeremy.Fitzhardinge@citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: Q: Clarification about extra option ..Re: Re: [PATCH] pvops: Make suspend work when CONFIG_SUSPEND=n
Date: Mon, 7 Mar 2011 12:53:25 -0500 [thread overview]
Message-ID: <20110307175325.GC4930@dumpdata.com> (raw)
In-Reply-To: <AANLkTimL2srKo2n0jEfWzyexByfaCRg34UkVSNPRRqXL@mail.gmail.com>
On Mon, Mar 07, 2011 at 08:33:25AM -0800, Shriram Rajagopalan wrote:
> On Mon, Mar 7, 2011 at 4:44 AM, Stefano Stabellini <
> stefano.stabellini@eu.citrix.com> wrote:
>
> > On Sun, 6 Mar 2011, Rafael J. Wysocki wrote:
> > > > The only issue is that I cannot completely "test" these two patches
> > > > against Rafael's tree
> > > > - I have verified that the kernel config file generated is as
> > expected.
> > > > - I cannot verify any other xen save/restore functionality as my xen
> > > > suspend freeze-thaw patches dont apply cleanly on Rafael's tree
> > > > (it does not have xen suspend refactoring patches
> > > > ceb180294790c8a6a437533488616f6b591b49d0, that my patches depend on.
> > > > They are present only in Stefano's tree).
> > >
> > > In that case, I'm afraid, it's better to wait until both trees are merged
> > > and push your patches at that time.
<nods> But we need to review/test/etc his patches before the merge window..
> >
> > I agree even if it probably means loosing the next merge window.
> >
> > I believe the original intention of the freeze-thaw patches was to fix the
> bug that caused
> Guest VM hangs, while taking a checkpoint.
>
> Anyway, is there any chance of pushing these patches into the pvops tree
> atleast?
> I can rebase them to pvops.
so Shriram could create a branch that has both Stefano's (and also Ian's patches)
and Rafeal's tree and you can use that. And when the merge window happens
we would let Stefano's and Rafeal's tree go in and after that ask Linus to pull
this complicated tree.
That means you are going to have to create this hybrid tree. You can create a git branch
from Stefano's tree, merge in Rafael's tree, and test it (baremetal and also Xen).
Once you are satisfied that it works and it is bug-free:
a). send the tar ball to me (or just a link).
b). I am going to extract that branch in my tree
c). You are going to post the patches that you had to develop so we can review
them.
d). If everybody is happy and testing on our test-beds is OK, I can push this tree
later in the merge window cycle.
It is a bit of dance but it ought to work out?
next prev parent reply other threads:[~2011-03-07 17:53 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 11:20 [PATCH] pvops: Make suspend work when CONFIG_SUSPEND=n Frank Pan
2011-03-04 11:35 ` Ian Campbell
2011-03-04 11:45 ` Frank Pan
2011-03-04 11:52 ` Ian Campbell
2011-03-04 15:42 ` Shriram Rajagopalan
2011-03-04 15:56 ` Konrad Rzeszutek Wilk
2011-03-04 16:29 ` Shriram Rajagopalan
2011-03-04 18:26 ` Q: Clarification about extra option ..Re: " Konrad Rzeszutek Wilk
2011-03-04 19:49 ` Shriram Rajagopalan
2011-03-04 20:07 ` Rafael J. Wysocki
2011-03-06 20:31 ` Shriram Rajagopalan
2011-03-06 22:12 ` Rafael J. Wysocki
2011-03-07 12:44 ` Stefano Stabellini
2011-03-07 16:33 ` Shriram Rajagopalan
2011-03-07 17:53 ` Konrad Rzeszutek Wilk [this message]
2011-03-07 18:17 ` Shriram Rajagopalan
2011-03-08 15:53 ` Konrad Rzeszutek Wilk
2011-03-07 17:39 ` Konrad Rzeszutek Wilk
2011-03-04 20:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307175325.GC4930@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Jeremy.Fitzhardinge@citrix.com \
--cc=frankpzh@gmail.com \
--cc=rshriram@cs.ubc.ca \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).