From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: Re: [PATCH v2] xen/gntdev, gntalloc: Remove unneeded VM flags
Date: Wed, 9 Mar 2011 12:05:34 -0500 [thread overview]
Message-ID: <20110309170534.GC8049@dumpdata.com> (raw)
In-Reply-To: <1299578040.17339.413.camel@zakaz.uk.xensource.com>
> > @@ -471,8 +483,6 @@ static int gntalloc_mmap(struct file *filp, struct vm_area_struct *vma)
> > vma->vm_private_data = gref;
> >
> > vma->vm_flags |= VM_RESERVED;
> > - vma->vm_flags |= VM_DONTCOPY;
> > - vma->vm_flags |= VM_PFNMAP | VM_PFN_AT_MMAP;
So the gntalloc driver can be used on PV. You remove the DONTCOPY,PFNMAP, and PFN_AT_MMAP
.. while
> > - vma->vm_flags |= VM_RESERVED|VM_DONTCOPY|VM_DONTEXPAND|VM_PFNMAP;
> > + vma->vm_flags |= VM_RESERVED|VM_DONTEXPAND;
> > +
> > + if (use_ptemod)
> > + vma->vm_flags |= VM_DONTCOPY|VM_PFNMAP;
> >
Here (gntdev) you are more careful. Should we do the same check under PV
for the gntalloc driver?
Have you tested this driver in PV <-> HVM env?
next prev parent reply other threads:[~2011-03-09 17:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-07 18:19 [PATCH] xen/gntdev,gntalloc: Remove unneeded VM flags Daniel De Graaf
2011-03-07 19:53 ` Ian Campbell
2011-03-07 20:01 ` [PATCH] xen/gntdev, gntalloc: " Daniel De Graaf
2011-03-07 20:18 ` [PATCH v2] " Daniel De Graaf
2011-03-08 9:54 ` Ian Campbell
2011-03-09 17:05 ` Konrad Rzeszutek Wilk [this message]
2011-03-09 18:38 ` Daniel De Graaf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110309170534.GC8049@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=dgdegra@tycho.nsa.gov \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).