* processor_xen.o should depend on CONFIG_XEN
@ 2011-03-12 15:07 Olaf Hering
2011-03-15 18:13 ` Ian Jackson
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2011-03-12 15:07 UTC (permalink / raw)
To: xen-devel
By accident CONFIG_XEN got disabled in my .config. I noticed that in
xen.git/drivers/acpi/Makefile processor_xen.o is compiled unconditionally.
I think it should be processor-$(CONFIG_XEN) instead of processor-y
because it references xen_pcpu_index().
Olaf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: processor_xen.o should depend on CONFIG_XEN
2011-03-12 15:07 processor_xen.o should depend on CONFIG_XEN Olaf Hering
@ 2011-03-15 18:13 ` Ian Jackson
2011-03-18 15:23 ` [PATCH] " Olaf Hering
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2011-03-15 18:13 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel
Olaf Hering writes ("[Xen-devel] processor_xen.o should depend on CONFIG_XEN"):
> By accident CONFIG_XEN got disabled in my .config. I noticed that in
> xen.git/drivers/acpi/Makefile processor_xen.o is compiled unconditionally.
> I think it should be processor-$(CONFIG_XEN) instead of processor-y
> because it references xen_pcpu_index().
Would you care to write a patch to this effect ?
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] processor_xen.o should depend on CONFIG_XEN
2011-03-15 18:13 ` Ian Jackson
@ 2011-03-18 15:23 ` Olaf Hering
2011-03-18 16:32 ` Ian Jackson
2011-03-18 16:43 ` Konrad Rzeszutek Wilk
0 siblings, 2 replies; 6+ messages in thread
From: Olaf Hering @ 2011-03-18 15:23 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel
processor_xen.c references symbols which are only availabe if CONFIG_XEN
is enabled.
Signed-off-by: Olaf Hering <olaf@aepfle.de>
---
drivers/acpi/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile
===================================================================
--- linux-2.6.32.32-0.2-pvops.orig/drivers/acpi/Makefile
+++ linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile
@@ -61,7 +61,7 @@ obj-$(CONFIG_ACPI_POWER_METER) += power_
# processor has its own "processor." module_param namespace
processor-y := processor_core.o processor_throttling.o
processor-y += processor_idle.o processor_thermal.o
-processor-y += processor_xen.o
+processor-$(CONFIG_XEN) += processor_xen.o
processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] processor_xen.o should depend on CONFIG_XEN
2011-03-18 15:23 ` [PATCH] " Olaf Hering
@ 2011-03-18 16:32 ` Ian Jackson
2011-03-18 16:43 ` Konrad Rzeszutek Wilk
1 sibling, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2011-03-18 16:32 UTC (permalink / raw)
To: Olaf Hering; +Cc: xen-devel@lists.xensource.com
Olaf Hering writes ("[PATCH] processor_xen.o should depend on CONFIG_XEN"):
> processor_xen.c references symbols which are only availabe if CONFIG_XEN
> is enabled.
Thanks. This should be sent to linux-kernel and perhaps go in via the
Xen tree ?
Ian.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] processor_xen.o should depend on CONFIG_XEN
2011-03-18 15:23 ` [PATCH] " Olaf Hering
2011-03-18 16:32 ` Ian Jackson
@ 2011-03-18 16:43 ` Konrad Rzeszutek Wilk
2011-03-18 17:20 ` Olaf Hering
1 sibling, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2011-03-18 16:43 UTC (permalink / raw)
To: Olaf Hering, Ian Campbell; +Cc: xen-devel, Ian Jackson
On Fri, Mar 18, 2011 at 04:23:33PM +0100, Olaf Hering wrote:
> processor_xen.c references symbols which are only availabe if CONFIG_XEN
> is enabled.
Hehe. I saw this for 2.6.38 some time ago from Ian Campbell and promptly
forgot. Now it comes up again. Will stick it on 2.6.39 bug-fix branch shortly.
>
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
>
> ---
> drivers/acpi/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile
> ===================================================================
> --- linux-2.6.32.32-0.2-pvops.orig/drivers/acpi/Makefile
> +++ linux-2.6.32.32-0.2-pvops/drivers/acpi/Makefile
> @@ -61,7 +61,7 @@ obj-$(CONFIG_ACPI_POWER_METER) += power_
> # processor has its own "processor." module_param namespace
> processor-y := processor_core.o processor_throttling.o
> processor-y += processor_idle.o processor_thermal.o
> -processor-y += processor_xen.o
> +processor-$(CONFIG_XEN) += processor_xen.o
> processor-$(CONFIG_CPU_FREQ) += processor_perflib.o
>
> obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] processor_xen.o should depend on CONFIG_XEN
2011-03-18 16:43 ` Konrad Rzeszutek Wilk
@ 2011-03-18 17:20 ` Olaf Hering
0 siblings, 0 replies; 6+ messages in thread
From: Olaf Hering @ 2011-03-18 17:20 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Ian Campbell, xen-devel, Ian Jackson
On Fri, Mar 18, Konrad Rzeszutek Wilk wrote:
> On Fri, Mar 18, 2011 at 04:23:33PM +0100, Olaf Hering wrote:
> > processor_xen.c references symbols which are only availabe if CONFIG_XEN
> > is enabled.
>
> Hehe. I saw this for 2.6.38 some time ago from Ian Campbell and promptly
> forgot. Now it comes up again. Will stick it on 2.6.39 bug-fix branch shortly.
Thats mainly for stable-2.6.32.x, if it applies to other trees too, fine
with me.
Olaf
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-18 17:20 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-12 15:07 processor_xen.o should depend on CONFIG_XEN Olaf Hering
2011-03-15 18:13 ` Ian Jackson
2011-03-18 15:23 ` [PATCH] " Olaf Hering
2011-03-18 16:32 ` Ian Jackson
2011-03-18 16:43 ` Konrad Rzeszutek Wilk
2011-03-18 17:20 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).