From mboxrd@z Thu Jan 1 00:00:00 1970 From: Olaf Hering Subject: Re: [PATCH 1 of 5] xentrace: fix t_info_pages calculation for the default case Date: Wed, 23 Mar 2011 14:16:02 +0100 Message-ID: <20110323131602.GA7561@aepfle.de> References: <4D89D5920200007800037DBE@vpn.id2.novell.com> <20110323112040.GB28535@aepfle.de> <4D89F98F0200007800037E68@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <4D89F98F0200007800037E68@vpn.id2.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jan Beulich Cc: xen-devel@lists.xensource.com, Keir Fraser , George Dunlap List-Id: xen-devel@lists.xenproject.org On Wed, Mar 23, Jan Beulich wrote: > >>> On 23.03.11 at 12:20, Olaf Hering wrote: > > I did not know about PFN_UP() until now, using it would work as well. > > Note that one caveat with using it here is that you'd first need to > move its definition from include/asm-x86/page.h to somewhere > under include/xen/ - perhaps having a pfn.h like Linux does would > make sense. Yes, if thats ok with Keir I will do that. Otherwise I could just open code the functionality for t_info_pages. Olaf