From: Wim Van Sebroeck <wim@iguana.be>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Priyanka Gupta <priyankag@google.com>,
Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
linux-watchdog@vger.kernel.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Mike Waychison <mikew@google.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -v3 -resend] watchdog, SP5100: Check if firmware has set correct value in tcobase.
Date: Thu, 24 Mar 2011 09:31:20 +0100 [thread overview]
Message-ID: <20110324083120.GC4968@infomag.iguana.be> (raw)
In-Reply-To: <4D8AD791.9010602@kernel.org>
Hi Yinghai,
> Stefano found SP5100 TCO watchdog driver using wrong address.
>
> [ 9.148536] SP5100 TCO timer: SP5100 TCO WatchDog Timer Driver v0.01
> [ 9.148628] DEBUG __ioremap_caller WARNING address=b8fe00 size=8 valid=1 reserved=1
>
> and e820 said that range is RAM.
>
> We should check if we can use that reading out. BIOS could just program wrong address there.
>
> -v2: Mike pointed out one path need one release.
> -v3: corrected logic checking with request_mem_region_exclusive()
> Found by Konrad.
>
>
> Reported-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
> Signed-off-by:Yinghai Lu <yinghai@kernel.org>
> Acked-by: Mike Waychison <mikew@google.com>
> Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
This patch is in linux-2.6-watchdog-next for a week now. Will go upstream to linus.
Kind regards,
Wim.
next prev parent reply other threads:[~2011-03-24 8:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 13:17 [GIT PULL tip/x86/mm] xen/x86 fixes Stefano Stabellini
2011-03-11 22:21 ` Konrad Rzeszutek Wilk
2011-03-16 12:28 ` Stefano Stabellini
2011-03-16 14:43 ` Stefano Stabellini
2011-03-16 17:55 ` Yinghai Lu
2011-03-16 18:02 ` Stefano Stabellini
2011-03-16 20:45 ` [GIT PULL tip/x86/mm] xen/x86 fixes ===> fix sp5100_tco mmio checking Yinghai Lu
2011-03-16 21:01 ` Mike Waychison
2011-03-16 21:18 ` [PATCH] watchdog, SP5100: Check if firmware has set correct value in tcobase Yinghai Lu
2011-03-17 0:00 ` Konrad Rzeszutek Wilk
2011-03-17 2:23 ` Konrad Rzeszutek Wilk
2011-03-17 3:01 ` [PATCH -v3] " Yinghai Lu
2011-03-18 13:10 ` [Xen-devel] " Konrad Rzeszutek Wilk
2011-03-18 16:39 ` Yinghai Lu
2011-03-17 12:35 ` [PATCH] " Stefano Stabellini
2011-03-24 5:33 ` [PATCH -v3 -resend] " Yinghai Lu
2011-03-24 8:31 ` Wim Van Sebroeck [this message]
2011-03-24 15:40 ` Yinghai Lu
2011-03-17 12:44 ` [GIT PULL tip/x86/mm] xen/x86 fixes Stefano Stabellini
2011-03-17 17:25 ` Yinghai Lu
2011-03-17 17:38 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324083120.GC4968@infomag.iguana.be \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mikew@google.com \
--cc=priyankag@google.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).