From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] PM / Hibernate: Introduce CONFIG_HIBERNATE_INTERFACE Date: Wed, 30 Mar 2011 23:10:24 +0200 Message-ID: <201103302310.24717.rjw@sisk.pl> References: <201103261229.44770.rjw@sisk.pl> <1301414013.18413.29.camel@zakaz.uk.xensource.com> <201103292139.35645.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201103292139.35645.rjw@sisk.pl> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Shriram Rajagopalan , "linux-pm@lists.linux-foundation.org" , "xen-devel@lists.xensource.com" , LKML List-Id: xen-devel@lists.xenproject.org On Tuesday, March 29, 2011, Rafael J. Wysocki wrote: > On Tuesday, March 29, 2011, Ian Campbell wrote: > > Hi Rafael, > > > > On Sat, 2011-03-26 at 11:29 +0000, Rafael J. Wysocki wrote: > > > From: Rafael J. Wysocki > > > > > > Xen save/restore is going to use hibernate device callbacks for > > > quiescing devices and putting them back to normal operations and it > > > would need to select CONFIG_HIBERNATION for this purpose. However, > > > that also would cause the hibernate interfaces for user space to be > > > enabled, which might confuse user space, because the Xen kernels > > > don't support hibernation. Moreover, it would be wasteful, as it > > > would make the Xen kernels include a substantial amount of code that > > > they would never use. > > > > > > To address this issue introduce new power management Kconfig option > > > CONFIG_HIBERNATE_INTERFACE, such that the hibernate interfaces for > > > user space and the image-handling code will depend on it and it will > > > select CONFIG_HIBERNATION. Then, Xen save/restore will be able to > > > select CONFIG_HIBERNATION without dragging the entire hibernate code > > > along with it. > > > > > > Signed-off-by: Rafael J. Wysocki > > > > Were you planning to put this forward for 2.6.39 or are you waiting for > > 2.6.40? > > I'm goint to push it for 2.6.39. In fact, I'm going to send the pull request > shortly. Unfortunately Linus didn't like it, so I need to rework it to make him happy. As a result the patch is not going to go into 2.6.39. Thanks, Rafael