xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Wang2 <wei.wang2@amd.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [PATCH] AMD IOMMU: Unmapped interrupt should result io page fault
Date: Fri, 8 Apr 2011 14:13:43 +0200	[thread overview]
Message-ID: <201104081413.43427.wei.wang2@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

This could help us to debug interrupt related issues.
Thanks,
Wei
--
Advanced Micro Devices GmbH
Sitz: Dornach, Gemeinde Aschheim, 
Landkreis München Registergericht München, 
HRB Nr. 43632
WEEE-Reg-Nr: DE 12919551
Geschäftsführer:
Alberto Bozzo, Andrew Bowd

[-- Attachment #2: unmapped_intr.patch --]
[-- Type: text/x-diff, Size: 1185 bytes --]

# HG changeset patch
# User Wei Wang <wei.wang2@amd.com>
# Node ID 2bd2f621160b93a9f8cb6e21fd1a984d7ae2f51d
# Parent  ab2944070ca99790546b34fa04a80103d3e7464f
Unmapped interrupt should generate IO page faults. This helps us to debug interrupt issues.

Signed-off-by Wei Wang <wei.wang2@amd.com>

diff -r ab2944070ca9 -r 2bd2f621160b xen/drivers/passthrough/amd/iommu_map.c
--- a/xen/drivers/passthrough/amd/iommu_map.c	Fri Apr 08 12:35:48 2011 +0200
+++ b/xen/drivers/passthrough/amd/iommu_map.c	Fri Apr 08 13:54:28 2011 +0200
@@ -327,8 +327,9 @@ void amd_iommu_set_intremap_table(u32 *d
     set_field_in_reg_u32(0xB, entry,
                          IOMMU_DEV_TABLE_INT_TABLE_LENGTH_MASK,
                          IOMMU_DEV_TABLE_INT_TABLE_LENGTH_SHIFT, &entry);
-    /* ignore unmapped interrupts */
-    set_field_in_reg_u32(IOMMU_CONTROL_ENABLED, entry,
+
+    /* unmapped interrupt results io page faults*/
+    set_field_in_reg_u32(IOMMU_CONTROL_DISABLED, entry,
                          IOMMU_DEV_TABLE_INT_TABLE_IGN_UNMAPPED_MASK,
                          IOMMU_DEV_TABLE_INT_TABLE_IGN_UNMAPPED_SHIFT, &entry);
     set_field_in_reg_u32(int_valid ? IOMMU_CONTROL_ENABLED :

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2011-04-08 12:13 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104081413.43427.wei.wang2@amd.com \
    --to=wei.wang2@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).