From mboxrd@z Thu Jan  1 00:00:00 1970
From: Wei Wang2 <wei.wang2@amd.com>
Subject: Re: [PATCH] AMD IOMMU: Fix an interrupt remapping issue
	(v2)
Date: Mon, 11 Apr 2011 09:39:34 +0200
Message-ID: <201104110939.34840.wei.wang2@amd.com>
References: <201104081335.36718.wei.wang2@amd.com>
	<201104081852.20738.wei.wang2@amd.com>
	<4DA2C89A020000780003AD92@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4DA2C89A020000780003AD92@vpn.id2.novell.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jan Beulich <JBeulich@novell.com>
Cc: "Ostrovsky, Boris" <Boris.Ostrovsky@amd.com>, "Huang2,
	Wei" <Wei.Huang2@amd.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On Monday 11 April 2011 09:23:38 Jan Beulich wrote:
> >>> On 08.04.11 at 18:52, Wei Wang2 <wei.wang2@amd.com> wrote:
> >
> > Jan, How dose this one look like to you?
>
> Much better, but still not quite there: The unmasking must happen
> *after* the writing of the upper half (if that's what is being modified).
>
> You could also skip the unmasking altogether if saved_mask == 1.
>
> And if you start using __io_apic_write() (which I find very desirable)
> is there a reason not to use it (and __io_apic_read()) in all of the
> other places you touch anyway, too?
>
> Jan

Good points. I will send a new version addressing the remaining issues.
Thanks,
Wei