From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2 of 4] x86: make the pv-only e820 array be dynamic Date: Tue, 12 Apr 2011 08:53:17 -0400 Message-ID: <20110412125317.GA19198@dumpdata.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Ian Jackson , Ian.Campbell@citrix.com, Tim.Deegan@citrix.com List-Id: xen-devel@lists.xenproject.org On Tue, Apr 12, 2011 at 01:32:01PM +0100, Keir Fraser wrote: > On 11/04/2011 22:35, "Konrad Rzeszutek Wilk" wrote: > > > # HG changeset patch > > # User Konrad Rzeszutek Wilk > > # Date 1302295108 14400 > > # Node ID e7057fec103ba69776d157d470d630ce99dbc540 > > # Parent 0f279f43f41ffa8549e076f2a30f499bd8d6cc1d > > x86: make the pv-only e820 array be dynamic. > > > > During creation of the PV domain we allocate the E820 structure to > > have the amount of E820 entries on the machine, plus the number three. > > How cunning. > > Why wouldn't you just allocate exactly the right size of array in > XENMEM_set_memory_map? I was thinking about it, but the mm.c code did not have the xen/xmalloc.h header, nor any references to xmalloc_array. Is it OK to make an xmalloc_array during a hypercall?