From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Keith Swett <swettk@gmail.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: Trying to track down odd behavior, errors in xen dmesg
Date: Tue, 12 Apr 2011 18:48:40 -0400 [thread overview]
Message-ID: <20110412224840.GA9512@dumpdata.com> (raw)
In-Reply-To: <BANLkTikYWd4KU4dP2FBjFhZOLzkdgKjEDw@mail.gmail.com>
On Tue, Apr 12, 2011 at 04:23:13PM -0500, Keith Swett wrote:
> Konrad,
Please don't top-post.
> I found an error in my process.
> On line 225 of the patch, there's a single parenthesis. What should
> the lines in this area (418-420 of blkback.c) look like after the
Here is the git tree with the patch:
http://git.kernel.org/?p=linux/kernel/git/konrad/xen.git;a=shortlog;h=refs/heads/devel/blkback-vi
And the file
http://git.kernel.org/?p=linux/kernel/git/konrad/xen.git;a=blob;f=drivers/xen/blkback/blkback.c;h=13c51257f2d4f87330f13820a372abcff63864b4;hb=89856e4d890a04ce79c6e38c33b5fb873e7fc6df
And I think you are referring to this:
417
418 if (atomic_dec_and_test(&pending_req->pendcnt)) {
419 pending_req->id, duration); <<---
420 if (unlikely(fast_flush_area(pending_req))) {
421 /* Granted page(s) are still being referenc
Take out line 419.
next prev parent reply other threads:[~2011-04-12 22:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 16:30 Trying to track down odd behavior, errors in xen dmesg Keith Swett
2011-04-07 13:54 ` Konrad Rzeszutek Wilk
2011-04-07 14:45 ` Keith Swett
2011-04-07 15:52 ` Keith Swett
2011-04-07 16:01 ` Konrad Rzeszutek Wilk
2011-04-07 16:02 ` Keith Swett
2011-04-07 16:23 ` Konrad Rzeszutek Wilk
2011-04-07 16:39 ` Keith Swett
2011-04-08 13:40 ` Keith Swett
2011-04-08 13:53 ` Konrad Rzeszutek Wilk
2011-04-08 13:59 ` Keith Swett
2011-04-12 10:20 ` Konrad Rzeszutek Wilk
2011-04-12 16:20 ` Keith Swett
2011-04-12 20:41 ` Konrad Rzeszutek Wilk
2011-04-12 20:59 ` Keith Swett
2011-04-12 21:08 ` Konrad Rzeszutek Wilk
2011-04-12 21:23 ` Keith Swett
2011-04-12 22:48 ` Konrad Rzeszutek Wilk [this message]
2011-04-12 23:02 ` Keith Swett
2011-04-13 13:05 ` Konrad Rzeszutek Wilk
2011-04-14 13:24 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412224840.GA9512@dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=swettk@gmail.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).