From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: Trying to track down odd behavior, errors in xen dmesg Date: Tue, 12 Apr 2011 18:48:40 -0400 Message-ID: <20110412224840.GA9512@dumpdata.com> References: <20110408135337.GG6189@dumpdata.com> <20110412102002.GA30108@dumpdata.com> <20110412204123.GA7308@dumpdata.com> <20110412210810.GB21002@dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keith Swett Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tue, Apr 12, 2011 at 04:23:13PM -0500, Keith Swett wrote: > Konrad, Please don't top-post. > I found an error in my process. > On line 225 of the patch, there's a single parenthesis. What should > the lines in this area (418-420 of blkback.c) look like after the Here is the git tree with the patch: http://git.kernel.org/?p=linux/kernel/git/konrad/xen.git;a=shortlog;h=refs/heads/devel/blkback-vi And the file http://git.kernel.org/?p=linux/kernel/git/konrad/xen.git;a=blob;f=drivers/xen/blkback/blkback.c;h=13c51257f2d4f87330f13820a372abcff63864b4;hb=89856e4d890a04ce79c6e38c33b5fb873e7fc6df And I think you are referring to this: 417 418 if (atomic_dec_and_test(&pending_req->pendcnt)) { 419 pending_req->id, duration); <<--- 420 if (unlikely(fast_flush_area(pending_req))) { 421 /* Granted page(s) are still being referenc Take out line 419.